Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Incorrect application owner #5

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

brunomenezes
Copy link
Collaborator

Summary

Code changes to update the application owner when the OwnershipTransferred event is emitted.

Changes:

  • Added CartesiDApp Abi
  • Added new Log topic 0 to listen to OwnershipTransferred events
  • Added a new Handler to keep track of OwnershipTransferred and update applications of interest.

closes #4

@brunomenezes brunomenezes requested a review from tuler September 14, 2023 07:07
@brunomenezes brunomenezes linked an issue Sep 14, 2023 that may be closed by this pull request
@tuler
Copy link
Member

tuler commented Sep 14, 2023

Good job!

We just have to keep in mind that listtening to OwnershipTransferred reduces a lot our indexing performance and increases ETH gateway consumption, because that event is very frequent.

I processed mainnet locally and it takes 2 minutes, 10 seconds to get to the Honeypot application.
While without scanning OwnershipTransferred it takes only 21 seconds.

Considerations about this issue is discussed at https://docs.subsquid.io/evm-indexing/factory-contracts/#two-pass-indexing-for-factory-contracts

@brunomenezes brunomenezes merged commit c655210 into main Sep 14, 2023
1 check passed
@brunomenezes brunomenezes deleted the fix/4-incorrect-application-owner branch September 14, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Application owner
2 participants