Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added in Identity Center Nodes + relationship mapping #1380
Added in Identity Center Nodes + relationship mapping #1380
Changes from all commits
98bafdc
d5ee38f
7c7a0fa
33ba7ec
762d066
1f0d702
c7d8bcf
3a97a35
c442b83
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the data model here. I think we can do this by creating a
SSOUserToRole
relationship.We can have a
transform
step that shapes the data returned fromget_sso_users()
andget_role_assignments()
into what we need.This way we don't have to use
neo4j_session.run()
(since this can fail and does not retry automatically), and the data model does batching and automatic cleanups and all that.Let's get on a call if you're stuck with this. I'm also happy to push changes up to your branch if that's easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as above. There is no easy transform as it depends on relationships based on data already in the graph. I have to find the specific role by doing
I am looking for a role in the middle of the AWSAccount -> AWSPermissionSet path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(notes to self) Per our convo: AWS identitycenter is weird. SSO users are associated with perm sets, and can be assigned to roles, but this assignment only takes place in one account.