Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change security slack notifications to alert based on open code scanning results #493

Closed
benmoss opened this issue Jan 25, 2022 · 2 comments
Assignees
Labels
kind/cleanup engineering focused non-feature work

Comments

@benmoss
Copy link
Contributor

benmoss commented Jan 25, 2022

Right now our Trivy code scanning workflow will send Slack alerts based on whether the Trivy CLI finds any unresolved issues in our images/binaries. It also posts them to GitHub's Code Scanning tool for our repo, which allows us to mark them as resolved/wontfix.

The problem is that if we have a wontfix it will be closed from GitHub, but Trivy will still report it as present. If we could trigger based on the open Code Scanning tickets instead we could have a better picture of unresolved items. It looks like it should be possible using GitHub's API.

If we get this working we should also fix this with other Carvel projects.

@benmoss benmoss added carvel-triage This issue has not yet been reviewed for validity kind/cleanup engineering focused non-feature work and removed carvel-triage This issue has not yet been reviewed for validity labels Jan 25, 2022
@benmoss benmoss self-assigned this Jan 25, 2022
@benmoss
Copy link
Contributor Author

benmoss commented Jan 26, 2022

This turned out to be slightly more complicated than I thought since we're scanning the latest release as well. I don't think there's a good way to associate a code scan alert with a release, so for instance if we had a fixed vulnerability in develop but that was still vulnerable in the latest release, I'm not sure it's simple to distinguish where it's fixed

@benmoss benmoss closed this as completed Jan 26, 2022
@benmoss
Copy link
Contributor Author

benmoss commented Jan 27, 2022

Reopening since this is gonna bother me forever. I looked into it a bit today but was blocked by github/codeql-action#890. There looks like there will be a fix there shortly so I'll revisit once that's merged.

@benmoss benmoss reopened this Jan 27, 2022
@github-actions github-actions bot added the carvel-triage This issue has not yet been reviewed for validity label Jan 27, 2022
@benmoss benmoss removed the carvel-triage This issue has not yet been reviewed for validity label Jan 27, 2022
@benmoss benmoss closed this as completed Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup engineering focused non-feature work
Projects
None yet
Development

No branches or pull requests

1 participant