-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep original tag and only append sha256 digest #309
Comments
Hey @nuriel77, thanks for opening up this issue. Do you mind explaining to us a little more about your use case for this? |
@joaopapereira Hi! Yes, so basically when you keep the tag it is easier to see which version of the image is being used rather than just having the SHA alone.
This is useful when checking pods and their deployed images to infer the version. |
What @nuriel77 said. In addition, there are the following arguments:
|
Hey Is this something that yll would want to happen by default or only done when a configuration is done? If we decide to do this by default this might cause issues to people that are currently using apiVersion: kbld.k14s.io/v1alpha1
kind: Config
overrides:
- image: nginx:1.2.3
keepTag: true What do yll think? |
Valid concern. |
Agreed, looks good enough for me. |
Cool, going to accept this feature. |
Describe the problem/challenge you have
[A description of the current challenge that you are experiencing.]
Sorry if I have missed this while checking the documentation, but is it possible to maintain the original tag and simply append the digest? The effect would be the same, while keeping the image's original version tag readable.
Describe the solution you'd like
[A clear and concise description of what you want to happen. If applicable a visual representation of the UX (ex: new CLI argument name, the behavior expected).]
For example:
nginx:1.14.2
Would become:
index.docker.io/library/nginx:1.14.2@sha256:f7988fb6c02e0ce69257d9bd9cf37ae20a60f1df7563c3a2a6abe24160306b8d
Anything else you would like to add:
[Additional information that will assist in solving the issue.]
Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.
The text was updated successfully, but these errors were encountered: