-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding annotations to the pod template #441
Comments
It just occurred to me that you probably decided to add the annotations to the outer manifest because |
This issue is being marked as stale due to a long period of inactivity and will be closed in 5 days if there is no response. |
Hey |
@joaopapereira Thanks. Your comment pretty much confirmed my assumption from my previous comment. I think that's reasonable. If I absolutely need the annotations on the podSpec, I could probably write my own tooling to just move/copy the annotations around after kbld added them. |
Hi! We've been using kbld for over two years now with huge success. Thanks! There is just a tiny thing that is bugging us:
Describe the problem/challenge you have
As it is usually done, we scrape our pods to collect metrics from them. When using
kbld
, the deployed image-tag cannot be retrieved just by looking at the pods. Unfortunately, kbld adds its annotations to the owning object (Deployment, StatefulSet, ...) only, but not to its pod template.Concrete example: We have this manifest:
When feeding it to kbld, it resolves the tags and adds its annotations:
Instead, I would like to see the annotations also (or exclusively, maybe guarded by an option) added to the pod template:
I don't really care about the annotations on the outer Manifest. Maybe it should be an option to add the annotations to the pod-template only.
Describe the solution you'd like
I don't really care if this proposed behaviour gets enabled by default or if this would be opt-in using some kind of option. Maybe this could be configured using a new annotation on the outer manifest, like so:
Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.
The text was updated successfully, but these errors were encountered: