Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version to 1.22.5 #498

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

devanshuVmware
Copy link
Contributor

Bump go version to 1.22.5

Signed-off-by: devanshuVmware <devanshu.d@broadcom.com>
@joaopapereira
Copy link
Member

Can we, as part of this PR also change the test that is failing? I am assuming it is just changing to a different image or SHA that exists in docker hub.
Thanks

test-gh build fails as the repo has been removed

Signed-off-by: devanshuVmware <devanshu.d@broadcom.com>
Signed-off-by: devanshuVmware <devanshu.d@broadcom.com>
@devanshuVmware
Copy link
Contributor Author

Can we, as part of this PR also change the test that is failing? I am assuming it is just changing to a different image or SHA that exists in docker hub. Thanks

@joaopapereira It was failing as the image for cloudfoundry/capi-kpack-watcher doesn't exist anymore in dockerhub. So I have removed the check for capi-kpack-watcher image from the relevant tests

@praveenrewar praveenrewar merged commit 4605e28 into carvel-dev:develop Jul 17, 2024
4 checks passed
@devanshuVmware devanshuVmware deleted the bump-go-1-22-5 branch July 17, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants