-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for the Provisioned Service defined in the Service Binding Specification for Kubernetes #95
Comments
Thanks @baijum for contributing. I'm not familiar with the docs you linked but from a quick read it seems like you're proposing that we conform to this standard or API. Can you tell us more about your use-case, what your goals, and how they would be made simpler or enabled by SecretTemplate adopting these standards? |
For reference we had a bit of discussion about this in the original issue see #54 (comment) In the end we decided to not adopt it by default initially for two reasons:
However we left the door open for this being added in the future. I think providing compliance to @baijum what are your thoughts on using a direct secret reference vs ProvisionedService? |
Thanks, @Samze, for pointing out the original issue (#54) with a discussion about Provisioned Service. @joe-kimmel-vmw As described in the spec, Provisioned Service expects My current use case is to use AWS services using the AWS Controllers for Kubernetes and Regarding the use of Direct Secret Reference, there is a good explanation in the spec docs:
If |
Thanks @baijum! I agree this would be a good change to include. If theres broad agreement from other folks, would you be interested in contributing it? Though just to be clear we already integrate using a direct secret reference today. This works since today the generated bindable Secret is always the same name as the SecretTemplate itself. So by knowing the SecretTemplate name, you can create a ServiceBinding with a direct reference to the generated Secret. |
I am glad to hear that there is an interest in supporting this feature. However, I will wait for a consensus before proceeding with implementation. |
@cppforlife / @joe-kimmel-vmw / @neil-hickey do you have thoughts on this? |
Thanks @Samze and @baijum IIRC we had a very short chat about it last week and thought it sounded fine, esp. if someone wanted to contribute it. I'll let @cppforlife or @neil-hickey correct if my recollection is way off. |
it's good by me (sorry, i thought i already posted a comment) |
Does introducing an optional boolean field with a default value as |
nope, we are happy to accept it as part of the current api version. |
Describe the problem/challenge you have
I want to use the
SecretTemplate
API with implementations of the Service Binding Specification for Kubernetes.Describe the solution you'd like
Make the
SecretTemplate
API a Provisioned Service as defined in the Service Binding Specification for Kubernetes.Anything else you would like to add:
Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you would like to work on this issue.
The text was updated successfully, but these errors were encountered: