-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lang] anchors are not supported #186
Comments
we do want them to work since they may be used within third party configuration. |
this open PR to go-yaml fixes issue: go-yaml/yaml#364; however, after the fix cases like knative config:
present a challenge since they introduce duplicate keys. |
but the last key listed should just override no? I'm guessing there's something in the spec regarding the behaviour |
Some additional conversation/context in slack. |
Adding to list of issues to review during pre-IPM ==> recommended |
any progress on that? I'm attempting to port anchor heavy configurations to ytt and lack support for anchors is making it increasingly complicated |
@groundnuty asked
Unfortunately not, so far. We've been in a "wait and hope for upstream fix" for some time now. So, while technically "in progress" is correct, we're really blocked on this upstream fix... (or we decide to find a way to land it in our own fork). It be clear, it's in the Carvel maintainer's backlog 👍🏻 , but it's currently sitting below the OpenAPI Schema export feature 🤷🏻 . |
@pivotaljohn maybe it's somehow connected with the memorable moment, that go-yaml stopped supporting flexible/forward anchors? It broke a lot of anchoring features... here is the discussion, where you can find a commit that broke that: go-yaml/yaml#558 if that's the case you can just try to build with older version of go-yaml and see if it works, and if it does remove the anchor-breaking changes form your fork. Just guessing here/trying to helpful :-) |
Appreciate that, @groundnuty. I'm looking into this. I'll update this comment with my "research", as I go. Facts:
|
This also stops me from migrating my yamls to ytt. |
FWIW, this issue was addressed on the main branch: #550 and will be included in the next release (coming soon). |
Released in v0.39.0. |
woot! thanks! |
I've seen #172 and the limitations and this prevents processing/installing knative resources with ytt.
https://github.com/knative/serving/blob/6c3eb0433d235d5ba9768ada4e7be90ddeb74458/config/core/resources/configuration.yaml#L26-L55
The text was updated successfully, but these errors were encountered: