Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexport is not backwards-compatible #2156

Closed
laniakea64 opened this issue Jun 14, 2024 · 1 comment · Fixed by #2158
Closed

unexport is not backwards-compatible #2156

laniakea64 opened this issue Jun 14, 2024 · 1 comment · Fixed by #2158

Comments

@laniakea64
Copy link
Contributor

Was playing with the new unexport syntax for vim-just and found some weird-looking backwards-incompatible behavior:

# In previous versions of just,
# these would create a recipe called "unexport" with parameters "QT_QPA_PLATFORMTHEME" and foo.
# In current just, they unexport QT_QPA_PLATFORMTHEME and create a recipe "foo"
unexport QT_QPA_PLATFORMTHEME \
foo:
	echo Not Foo
unexport QT_QPA_PLATFORMTHEME foo:
	echo Also Not Foo

# just 1.29.0 accepts this line as if it were the two lines
# unexport QT_QPA_PLATFORMTHEME
# and
# foo := 'bar'
# but shouldn't this actually be an error, as it is in previous just versions?
unexport QT_QPA_PLATFORMTHEME foo := 'bar'

# previous versions of just allowed "unexport" to be a recipe name or variable name
# these are now an error, even though they don't conflict with the documented unexport syntax
unexport := 'foo'

unexport:
	echo Unexport Recipe

unexport blah:
	echo {{quote(blah)}}
@casey
Copy link
Owner

casey commented Jun 14, 2024

Thanks for reporting this! Fixed in 1.28.1, which I just released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants