JdbcDriver - current transaction statements won't work for every dialect

[nikolajakshic]

If you run BEGIN TRANSACTION in MySQL, it'll crash.

sqldelight/drivers/jdbc-driver/src/main/kotlin/com/squareup/sqldelight/sqlite/driver/JdbcDriver.kt

Line 49 in 1c78cd3

getConnection().prepareStatement("BEGIN TRANSACTION").execute()

sqldelight/drivers/jdbc-driver/src/main/kotlin/com/squareup/sqldelight/sqlite/driver/JdbcDriver.kt

Lines 62 to 66 in 1c78cd3

	if (successful) {
	getConnection().prepareStatement("END TRANSACTION").execute()
	} else {
	getConnection().prepareStatement("ROLLBACK TRANSACTION").execute()
	}

Maybe it should be made dialect independent, by toggling Connection.setAutoCommit(boolean) and calling Connection.commit() / Connection.rollback() ?

[AlecKazakova]

Yup makes sense. What does setAutoCommit do?

[nikolajakshic]

From the docs:

If a connection is in auto-commit mode, then all its SQL statements will be executed and committed as individual transactions. Otherwise, its SQL statements are grouped into transactions that are terminated by a call to either the method commit or the method rollback. By default, new connections are in auto-commit mode.

[AlecKazakova]

Got it, so turning off autoCommit effectively starts a new transaction