Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for Kotlin 1.4 support #1859

Closed
6 of 7 tasks
JakeWharton opened this issue Jul 27, 2020 · 10 comments · Fixed by #1890
Closed
6 of 7 tasks

Release for Kotlin 1.4 support #1859

JakeWharton opened this issue Jul 27, 2020 · 10 comments · Fixed by #1890

Comments

@JakeWharton
Copy link
Collaborator

JakeWharton commented Jul 27, 2020

Tracking issue

Blocked on:

  • kotlinx.coroutines 1.3.9 release
    • kotlinx.coroutines 1.3.9 regular release
    • kotlinx.coroutines 1.3.9-native-mt release
  • Stately release for 1.4
  • Sqliter release for 1.4
  • Turbine release for 1.4 (Kotlin 1.4 release cashapp/turbine#6)
  • Update to Kotlin 1.4
@kpgalligan
Copy link
Collaborator

Working on it. We're releasing all the things on 1.4-rc

@joreilly
Copy link

joreilly commented Aug 1, 2020

Is hope to release version of SQLDelight corresponding to 1.4.0-rc or will you be waiting for final 1.4 release?

@JakeWharton
Copy link
Collaborator Author

I am personally not super enthusiastic about having a release build against an RC.

@joreilly
Copy link

joreilly commented Aug 1, 2020

I was more wondering I guess whether there might be an SQLDelight "1.4.-rc" version released (prior to proper 1.4 release)....as has been done for example for ktor, kotlinx serialization etc. I'm not sure how close we are to 1.4 release and whether it's worth the effort or not (and of course that's your call :) ). One other area this impacts is those projects that are tracking Jetpack Compose dev releases which has recently moved to being 1.4 based.

@JakeWharton
Copy link
Collaborator Author

It only impacts them if they're using native, right? Android, JVM, and JS projects should work fine with the current release I believe.

We're getting closer to automatic releases so if all our dependencies have updated we may be able to pull an RC release off. At the very least, let's get master and snapshots on 1.4 ASAP.

@edenman
Copy link

edenman commented Aug 4, 2020

fwiw I'm running into some issues with the sqldelight gradle plugin and kotlin 1.4-rc: https://issuetracker.google.com/issues/162779407
Not sure if updating SQLdelight to use 1.4-rc will fix but figured it was worth raising.

@uOOOO
Copy link

uOOOO commented Aug 15, 2020

Finally, 1.4.0 was released a few hours ago!

@russhwolf
Copy link

Stately update is released. Version 1.1.0 has Kotlin 1.4 support. touchlab/Stately#42

@ArtRoman
Copy link

touchlab/SQLiter 0.7.0 with Kotlin 1.4 support was released few hours ago

@JakeWharton
Copy link
Collaborator Author

Yep, Kevin is working on a branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

7 participants