Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups and tweaks to the Gradle plugin #3171

Merged
merged 9 commits into from
May 1, 2022
Merged

Minor cleanups and tweaks to the Gradle plugin #3171

merged 9 commits into from
May 1, 2022

Commits on May 1, 2022

  1. Remove "UnstableApiUsage" suppression 

    Worker API is stable from Gradle 7.0
    @3flex
    3flex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    0465bba View commit details
    Browse the repository at this point in the history

  2. Add IgnoreEmptyDirectories annoation to getSource in tasks 

    Specify that directories should be ignored when snapshotting inputs. This
annotation was added to the overridden function from Gradle 6.8
    @3flex
    3flex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    4d1bb43 View commit details
    Browse the repository at this point in the history

  3. Remove redundant InputFiles annotation 

    It's only necessary to add InputFiles if the Classpath annotation is used
to maintain compatibility with Gradle versions older than 3.2.
    @3flex
    3flex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    8097b5a View commit details
    Browse the repository at this point in the history

  4. Remove redundant workerExecutor override 

    The overridden property has an equivalent definition
    @3flex
    3flex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    bf7c6d9 View commit details
    Browse the repository at this point in the history

  5. Use Gradle's "all" distribution to enable IDE code-completion & type … 

    …hints
    @3flex
    3flex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    a9752c9 View commit details
    Browse the repository at this point in the history

  6. Use stricter validatation mode when validating Gradle plugin

    @3flex
    3flex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    81d3300 View commit details
    Browse the repository at this point in the history

  7. Add CacheableTask annotation to SqlDelightWorkerTask 

    Required when using stricter plugin validation
    @3flex
    3flex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    c6cefab View commit details
    Browse the repository at this point in the history

  8. Use managed properties 

    https://docs.gradle.org/7.4.2/userguide/custom_gradle_types.html#managed_properties
    @3flex
    3flex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    8af3ad0 View commit details
    Browse the repository at this point in the history

  9. Remove unused parameters in private functions

    @3flex
    3flex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    df21c5c View commit details
    Browse the repository at this point in the history