Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove constraint that Cask tokens cannot start with digits #7822

Merged
merged 4 commits into from
Dec 6, 2014

Conversation

rolandwalker
Copy link
Contributor

This PR works by adding an internal prefix to all Cask class names. Since the class names are now completely hidden from the user, the prefix is never seen.

This trick is considered to be an ugly transitional hack on the way to representing individual Casks as instances instead of classes.

Three Casks are also altered, but the change is backward-compatible and does not need to be coordinated with a code release.

@rolandwalker rolandwalker added the core Issue with Homebrew itself rather than with a specific cask. label Dec 5, 2014
instead of hardcoded class name
instead of hardcoded class name
instead of hardcoded class name
Class names are now completely hidden from the user.  This
commit works by adding a prefix to all Cask class names, which
is considered to be an ugly transitional hack on the way to
representing individual Casks as instances.
@rolandwalker rolandwalker force-pushed the allow_leading_numbers branch from 252183b to cb5a40f Compare December 5, 2014 16:55
rolandwalker added a commit that referenced this pull request Dec 6, 2014
Remove constraint that Cask tokens cannot start with digits
@rolandwalker rolandwalker merged commit a870869 into Homebrew:master Dec 6, 2014
@miccal miccal removed the core Issue with Homebrew itself rather than with a specific cask. label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants