Check for libpng to assure X11 detection #8519
Merged
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
added
the
core
Based on Homebrew's xquartz.rb. Improves Yosemite specifically. Fixes Homebrew#8483
rolandwalker
force-pushed
the
x11_detection
branch
from
3a79d7d to
74b46f7
Compare
rolandwalker
added a commit
that referenced
this pull request
Dec 30, 2014
Check for libpng to assure X11 detection
rolandwalker
added a commit
to rolandwalker/homebrew-cask
that referenced
this pull request
Dec 31, 2014
On review, the primary gain from adopting this code is the libpng detection method used in Homebrew#8519. The rest of the logic is not useful to us until/unless we start requiring specific X11 versions in `depends_on :x11`.
miccal
removed
the
core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Homebrew's xquartz.rb. Improves Yosemite specifically.
Fixes #8483