-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Now #27397
Added Now #27397
Conversation
It says on the webiste it auto-updates, so it needs a line like this. Also, if it auto-updates, that means it has an appcast somewhere. Can you add it? The |
@vitorgalvao Done! Do I need to update the |
Yes, if there is an |
sha256 :no_check | ||
|
||
# now-auto-updates.now.sh was verified as official when first introduced to the cask | ||
url 'https://now-auto-updates.now.sh/download/macos' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this to the URL provided in the releases page of github.
@@ -0,0 +1,15 @@ | |||
cask 'now' do | |||
version :latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a version
and sha256
.
Nowhere in that document does it state that’s a preference. Our users overwhelmingly prefer versioned casks for security reasons. We’re a service for users to easily install apps they want, not for developers to distribute them how they prefer. Even if you added this as unversioned, a user at a later date would change it to be versioned. If you follow the instructions in CONTRIBUTING, updating the whole cask with |
@vitorgalvao So there's basically no way to avoid having to push a new update to cask each time a new release comes out? 😊 |
No. Note that when the discussion first came up of preferring versioned or unversioned casks, I was on the unversioned camp. Users overwhelmingly prefer versioned casks, however. However, note that |
@vitorgalvao Ahh, cool. Thanks for the details! 😊 I guess I'll revisit this once you've automated the system. In my mind, it's not a solution for me to have to update the app over multiple channels. |
Keep in mind no one is making you keep it up to date. Submitting it is not a sentence to update it constantly. Most apps are user submitted and we have many great users (like @miccal and @artdevjs) and maintainers that keep the apps up to date, even the ones we don’t use personally. All that said, if you as the developer don’t even intend on running the one command to automatically keep it up to date, then I’d rather the submission indeed does not come from you, but from a user later on. That way, if there’s no user interested in having this in HBC, no point in the added overhead. Thank you for the submission, though! Those are always appreciated. |
Just added Now from my company @zeit to the Cask list! 😊
After making all changes to the cask:
brew cask audit --download {{cask_file}}
is error-free.brew cask style --fix {{cask_file}}
reports no offenses.Additionally, if adding a new cask:
brew cask install {{cask_file}}
worked successfully.brew cask uninstall {{cask_file}}
worked successfully.