Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Now #27397

Closed
wants to merge 3 commits into from
Closed

Added Now #27397

wants to merge 3 commits into from

Conversation

leo
Copy link
Contributor

@leo leo commented Dec 5, 2016

Just added Now from my company @zeit to the Cask list! 😊


After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked that the cask was not already refused in closed issues.

@vitorgalvao
Copy link
Contributor

It says on the webiste it auto-updates, so it needs a line like this.

Also, if it auto-updates, that means it has an appcast somewhere. Can you add it? The appcast documentation tells how.

@vitorgalvao vitorgalvao added the awaiting user reply Issue needs response from a user. label Dec 5, 2016
@leo
Copy link
Contributor Author

leo commented Dec 5, 2016

@vitorgalvao Done!

Do I need to update the appcast sha each time we update the app? Because that's exactly what I was trying to avoid by setting version to ":latest".

@miccal
Copy link
Contributor

miccal commented Dec 5, 2016

Do I need to update the appcast sha each time we update the app? Because that's exactly what I was trying to avoid by setting version to ":latest".

Yes, if there is an appcast then the version and sha256 also need to be set.

@leo
Copy link
Contributor Author

leo commented Dec 5, 2016

@miccal Then I should probably remove the appcast field again. Because this docs states that I don't need sha256 and version if I want it to be treated as unversioned by cask.

sha256 :no_check

# now-auto-updates.now.sh was verified as official when first introduced to the cask
url 'https://now-auto-updates.now.sh/download/macos'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to the URL provided in the releases page of github.

@@ -0,0 +1,15 @@
cask 'now' do
version :latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a version and sha256.

@vitorgalvao
Copy link
Contributor

vitorgalvao commented Dec 5, 2016

Because this docs states that I don't need sha256 and version if I want it to be treated as unversioned by cask.

Nowhere in that document does it state that’s a preference. Our users overwhelmingly prefer versioned casks for security reasons. We’re a service for users to easily install apps they want, not for developers to distribute them how they prefer. Even if you added this as unversioned, a user at a later date would change it to be versioned.

If you follow the instructions in CONTRIBUTING, updating the whole cask with cask-repair is literally one command away.

@leo
Copy link
Contributor Author

leo commented Dec 5, 2016

@vitorgalvao So there's basically no way to avoid having to push a new update to cask each time a new release comes out? 😊

@vitorgalvao
Copy link
Contributor

So there's basically no way to avoid having to push a new update to cask each time a new release comes out?

No. Note that when the discussion first came up of preferring versioned or unversioned casks, I was on the unversioned camp. Users overwhelmingly prefer versioned casks, however.

However, note that appcast was made with maintainers in mind. In the future, we’ll use it so you’ll never again have to update casks with an appcast (an automated system can do so).

@leo
Copy link
Contributor Author

leo commented Dec 6, 2016

@vitorgalvao Ahh, cool. Thanks for the details! 😊

I guess I'll revisit this once you've automated the system. In my mind, it's not a solution for me to have to update the app over multiple channels.

@leo leo closed this Dec 6, 2016
@vitorgalvao
Copy link
Contributor

Keep in mind no one is making you keep it up to date. Submitting it is not a sentence to update it constantly. Most apps are user submitted and we have many great users (like @miccal and @artdevjs) and maintainers that keep the apps up to date, even the ones we don’t use personally.

All that said, if you as the developer don’t even intend on running the one command to automatically keep it up to date, then I’d rather the submission indeed does not come from you, but from a user later on. That way, if there’s no user interested in having this in HBC, no point in the added overhead.

Thank you for the submission, though! Those are always appreciated.

@miccal miccal removed the awaiting user reply Issue needs response from a user. label Dec 23, 2016
@leo leo mentioned this pull request Jan 22, 2017
8 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants