Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't resolve for MAS build #101

Open
toschlog opened this issue Jun 29, 2021 · 3 comments
Open

Can't resolve for MAS build #101

toschlog opened this issue Jun 29, 2021 · 3 comments

Comments

@toschlog
Copy link

I'm getting a "cannot resolve" error for https://github.com/castlabs/electron-releases/releases/download/v10.4.3-wvvmp/electron-v10.4.3-wvvmp-mas-x64.zip. Is that URL wrong? I'm using electron-builder.

Thanks.

@khwaaj
Copy link
Collaborator

khwaaj commented Jun 29, 2021

Unfortunately we are not able to support MAS builds of ECS, see #10.

We do have one specific build that we made for interested parties to be able to try implementing MAS support, v12.0.5-wvvmp, but I have had no reports of successful attempts thus far.

@toschlog
Copy link
Author

I made a MAS build using 12.0.5 and submitted it. This is what I got back:

Your app links against the following non-public framework(s):

• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/CAContext
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/NSAccessibilityRemoteUIElement
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/NSNextStepFrame
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/NSThemeFrame
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/CALayerHost
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__NSAppendToKillRing
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_AudioDeviceDuck
• Contents/Frameworks/Electron Framework.framework/Versions/A/Helpers/chrome_crashpad_handler/__kCFSystemVersionProductVersionExtraKey
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__kCFSystemVersionProductVersionExtraKey
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_AXTextMarkerGetBytePtr
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_CTFontDescriptorIsSystemUIFont
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__NSYankFromKillRing
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__NSInitializeKillRing
• Contents/Frameworks/Electron Framework.framework/Versions/A/Helpers/chrome_crashpad_handler/__CFCopySystemVersionDictionary
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__CFCopySystemVersionDictionary
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_AXTextMarkerRangeCopyEndMarker
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_CGFontRenderingGetFontSmoothingDisabled
• Contents/Frameworks/Electron Framework.framework/Versions/A/Helpers/chrome_crashpad_handler/__kCFSystemVersionProductNameKey
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__kCFSystemVersionProductNameKey
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_AXTextMarkerRangeCopyStartMarker
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__NSNewKillRingSequence
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_IOBluetoothPreferenceSetControllerPowerState
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_CGSSetDenyWindowServerConnections
• Contents/Frameworks/Electron Framework.framework/Versions/A/Helpers/chrome_crashpad_handler/__CFCopyServerVersionDictionary
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__CFCopyServerVersionDictionary
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_CGDisplayUsesForceToGray
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__LSSetApplicationLaunchServicesServerConnectionStatus
• Contents/Frameworks/Electron Framework.framework/Versions/A/Helpers/chrome_crashpad_handler/__kCFSystemVersionProductVersionKey
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__kCFSystemVersionProductVersionKey
• Contents/Frameworks/Electron Framework.framework/Versions/A/Helpers/chrome_crashpad_handler/__kCFSystemVersionBuildVersionKey
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__kCFSystemVersionBuildVersionKey
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_AXTextMarkerCreate
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_NSTextInputReplacementRangeAttributeName
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_AXTextMarkerRangeGetTypeID
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_AXTextMarkerGetLength
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_AXTextMarkerRangeCreate
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_SetApplicationIsDaemon
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__NSSetKillRingToYankedState
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_AXTextMarkerGetTypeID

Are those modules all ones that are used by the WVVMP version?

@khwaaj
Copy link
Collaborator

khwaaj commented Aug 15, 2021

Interesting, I'd say most of these are not related to the Widevine integration, at least directly. To be able to support the CDM we are pulling in some additional Chromium code and it is not straightforward to tell exactly what non-public symbols this may indirectly pull in too.

There is also the fact that chrome_crashpad_handler is included in the package, which it should not be. I'll see if I can look into this a bit closer sometime next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants