TypeUtil.ToCSharpString(this Type) does not handle nested generic types correctly

[pmg23]

The useful extension method TypeUtil.ToCSharpString(this Type) does not correctly deal with types nested within generic types [as of Core 4.2.1]. For example:

internal class A<T1>
{
    internal class B {}
    internal class C<T2> {}
}

Assert.That(typeof(A<string>.B).ToCSharpString(),
        Is.EqualTo("A<String>.B")); // FAIL: actually "A<·T1·>.B<String>"
Assert.That(typeof(A<string>.C<int>).ToCSharpString(),
        Is.EqualTo("A<String>.C<Int32>")); // FAIL: actually "A<·T1·>.C<String, Int32>"

[stakx]

(Shameless advertisement:)

Type name formatting is surprisingly complex because there are quite a few corner cases to deal with. I happen to have written a small library recently (stakx/TypeNameFormatter) that would solve this problem. It's available as a source code NuGet package.

[stakx]

That being said, I cannot seem to find a method TypeUtil.ToCSharpString(this Type) in Castle Core (this repository). Did you mean this method in Castle Windsor (castleproject/Windsor)?

[stakx]

@pmg23, I've migrated this issue over to castleproject/Windsor#404, so please subscribe to the new issue. I'm closing this one here.

[pmg23]

Hi @stakx. Thanks for the quick response. I did indeed mean that one from Windsor. (The namespace, which I should have mentioned is Castle.Core.Internal, confused me.)

We'll definitely look into using stakx/TypeNameFormatter. Thanks for sharing it.