You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry, would make this a PR but I didn't have enough time to get around to it. Thanks again for adding prefixes so we could use models like E5. (issue #1720)
Hi @orionw , in pyserini.search.faiss, we are currently using AutoQueryEncoder from pyserini.encode, rather than pyserini.search.faiss._searcher. The AutoQueryEncoder in _searcher is deprecated and would be removed.
Hi there!
Sorry, would make this a PR but I didn't have enough time to get around to it. Thanks again for adding prefixes so we could use models like E5. (issue #1720)
When using an E5-like model though, the code uses AutoQueryEncoder which ignores the prefix for the query. It's a pretty simple fix (a few lines). See https://github.com/castorini/pyserini/blob/master/pyserini/search/faiss/_searcher.py#L371
It should be like it is for some of the other classes (like how DkrrDprQueryEncoder handles it) if I understand correctly:
pyserini/pyserini/search/faiss/_searcher.py
Line 244 in 2bb342a
and
pyserini/pyserini/search/faiss/_searcher.py
Line 233 in 2bb342a
If I am misunderstanding which class E5 models go to, lmk, but I think they are supposed to go to AutoQueryEncoder.
The text was updated successfully, but these errors were encountered: