Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo & bug #115

Closed
MXueguang opened this issue May 6, 2024 · 1 comment
Closed

typo & bug #115

MXueguang opened this issue May 6, 2024 · 1 comment

Comments

@MXueguang
Copy link
Member

MXueguang commented May 6, 2024 •
edited
Loading

  1. rank_llm/src/rank_llm/retrieve_and_rerank.py

    Line 121 in d62d111

    Request(copy.deepycopy(r.query), copy.deepcopy(r.candidates))

https://github.com/castorini/rank_llm/blob/d62d111784db4fea4312ca2a9941b91be80d057e/src/rank_llm/retrieve_and_rerank.py#L82C35-L82C48
@sahel-sh
Copy link
Member

Thank you Xueguang for filing this issue. We have made a lot of changes to the rankllm repo including fixing the typo in the function name. Would you please check the main branch, and if the bug is still present, elaborate on that?

@ronakice ronakice closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sahel-sh @ronakice @MXueguang