This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
Update to eslint 5 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 7, 2018 12:02
BREAKING CHANGE: Bumping eslint to v5 introduces new rules that can cause lint tasks to error out.
Removed deprecated/off.js and references in config files as now redundant.
…stent rather than multiline
camilleriluke
suggested changes
Aug 7, 2018
There was a problem hiding this comment.
Nice one @jackw 👏
Requesting one small update:
- Bump up the major version of this module since this will introduce a couple of "braking changes".
leventebalogh
approved these changes
Aug 7, 2018
rules/eslint/possible-errors/off.js
Outdated
| @@ -1,5 +1,8 @@ | |||
| module.exports = { | |||
| rules: { | |||
| 'for-direction': 0, | |||
| 'getter-return': 0, | |||
| 'no-async-promise-executor': 2, | |||
There was a problem hiding this comment.
Shouldn't it be 0 in the turned-off mode?
rules/eslint/stylistic-issues/on.js
Outdated
| blankLine: 'any', | ||
| prev: ['const', 'let', 'var'], | ||
| next: ['const', 'let', 'var'] | ||
| } |
There was a problem hiding this comment.
I would probably add { blankLine: "always", prev: "*", next: "return" } as well.
camilleriluke
approved these changes
Aug 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps all dependencies bringing eslint up to version 5. It removes the need for
deprecated.jsaseslint-find-rulesnow skips deprecated rules.I've set the majority of these new rules to their defaults but feel free to chip in with suggestions regarding the use of these new rules in line with our style guide.
Deprecated rules have been removed from the config files.
New rules introduced:
Deprecated rules: