From 1510f8189f5121e9743c257b0588dbcc0941901c Mon Sep 17 00:00:00 2001
From: scarf <greenscarf005@gmail.com>
Date: Wed, 9 Oct 2024 04:04:47 +0900
Subject: [PATCH] refactor: use concepts more (#5537)

* refactor: use `Arithmetic`

* refactor: use `SupportsProportional`, `SupportsRelative`

* refactor: MemberType
---
 src/assign.h           |  5 ++--
 src/generic_factory.h  | 62 ++++++++++++++++++++----------------------
 src/generic_readers.h  | 17 ++++++------
 src/numeric_interval.h |  4 ++-
 4 files changed, 44 insertions(+), 44 deletions(-)

diff --git a/src/assign.h b/src/assign.h
index d69394b00b96..c4ba8e82e871 100644
--- a/src/assign.h
+++ b/src/assign.h
@@ -18,6 +18,7 @@
 #include "json.h"
 #include "units.h"
 #include "units_serde.h"
+#include "concepts_utility.h"
 
 namespace detail
 {
@@ -43,7 +44,7 @@ bool is_strict_enabled( const std::string &src );
 void report_strict_violation( const JsonObject &jo, const std::string &message,
                               const std::string &name );
 
-template <typename T, typename std::enable_if<std::is_arithmetic<T>::value, int>::type = 0>
+template <Arithmetic T>
 bool assign( const JsonObject &jo, const std::string &name, T &val, bool strict = false,
              T lo = std::numeric_limits<T>::lowest(), T hi = std::numeric_limits<T>::max() )
 {
@@ -95,7 +96,7 @@ bool assign( const JsonObject &jo, const std::string &name, T &val, bool strict
 // and also to avoid potentially nonsensical interactions between relative and proportional.
 bool assign( const JsonObject &jo, const std::string &name, bool &val, bool strict = false );
 
-template <typename T, typename std::enable_if<std::is_arithmetic<T>::value, int>::type = 0>
+template <Arithmetic T>
 bool assign( const JsonObject &jo, const std::string &name, std::pair<T, T> &val,
              bool strict = false, T lo = std::numeric_limits<T>::lowest(), T hi = std::numeric_limits<T>::max() )
 {
diff --git a/src/generic_factory.h b/src/generic_factory.h
index 434245c62ada..6eff35cb6752 100644
--- a/src/generic_factory.h
+++ b/src/generic_factory.h
@@ -657,48 +657,45 @@ std::true_type {};
 template<>
 struct supports_proportional<bool> : std::false_type {};
 
+template<typename T>
+concept SupportsProportional = supports_proportional<T>::value;
+
 // This checks that all units:: types will support relative and proportional
-static_assert( supports_relative<units::energy>::value, "units should support relative" );
-static_assert( supports_proportional<units::energy>::value, "units should support proportional" );
+static_assert( SupportsRelative<units::energy>, "units should support relative" );
+static_assert( SupportsProportional<units::energy>, "units should support proportional" );
 
-static_assert( supports_relative<int>::value, "ints should support relative" );
-static_assert( supports_proportional<int>::value, "ints should support proportional" );
+static_assert( SupportsRelative<int>, "ints should support relative" );
+static_assert( SupportsProportional<int>, "ints should support proportional" );
 
-static_assert( !supports_relative<bool>::value, "bools should not support relative" );
-static_assert( !supports_proportional<bool>::value, "bools should not support proportional" );
+static_assert( !SupportsRelative<bool>, "bools should not support relative" );
+static_assert( !SupportsProportional<bool>, "bools should not support proportional" );
 
 // Using string ids with ints doesn't make sense in practice, but it doesn't matter here
 // The type that it is templated with does not change it's behavior
-static_assert( !supports_relative<string_id<int>>::value,
-               "string ids should not support relative" );
-static_assert( !supports_proportional<string_id<int>>::value,
+static_assert( !SupportsRelative<string_id<int>>, "string ids should not support relative" );
+static_assert( !SupportsProportional<string_id<int>>,
                "string ids should not support proportional" );
 
 // Using int ids with ints doesn't make sense in practice, but it doesn't matter here
 // The type that it is templated with does not change it's behavior
-static_assert( !supports_relative<int_id<int>>::value,
-               "int ids should not support relative" );
-static_assert( !supports_proportional<int_id<int>>::value,
-               "int ids should not support proportional" );
+static_assert( !SupportsRelative<int_id<int>>, "int ids should not support relative" );
+static_assert( !SupportsProportional<int_id<int>>, "int ids should not support proportional" );
 
-static_assert( !supports_relative<std::string>::value, "strings should not support relative" );
-static_assert( !supports_proportional<std::string>::value,
-               "strings should not support proportional" );
+static_assert( !SupportsRelative<std::string>, "strings should not support relative" );
+static_assert( !SupportsProportional<std::string>, "strings should not support proportional" );
 
 // Grab an enum class from debug.h
-static_assert( !supports_relative<DebugOutput>::value, "enum classes should not support relative" );
-static_assert( !supports_proportional<DebugOutput>::value,
-               "enum classes should not support proportional" );
+static_assert( !SupportsRelative<DebugOutput>, "enum classes should not support relative" );
+static_assert( !SupportsProportional<DebugOutput>, "enum classes should not support proportional" );
 
 // Grab a normal enum from there too
-static_assert( !supports_relative<DL>::value, "enums should not support relative" );
-static_assert( !supports_proportional<DL>::value, "enums should not support relative" );
+static_assert( !SupportsRelative<DL>, "enums should not support relative" );
+static_assert( !SupportsProportional<DL>, "enums should not support relative" );
 
 // Dummy template:
 // Warn if it's trying to use proportional where it cannot, but otherwise just
 // return.
-template < typename MemberType, std::enable_if_t < !supports_proportional<MemberType>::value > * =
-           nullptr >
+template<typename MemberType> requires( !SupportsProportional<MemberType> )
 inline bool handle_proportional( const JsonObject &jo, const std::string &name, MemberType & )
 {
     if( jo.has_object( "proportional" ) ) {
@@ -717,7 +714,7 @@ inline bool handle_proportional( const JsonObject &jo, const std::string &name,
 // this, so member will contain the value of the thing we inherit from
 // So, check if there is a proportional entry, check if it's got a valid value
 // and if it does, multiply the member by it.
-template<typename MemberType, std::enable_if_t<supports_proportional<MemberType>::value>* = nullptr>
+template<SupportsProportional MemberType>
 inline bool handle_proportional( const JsonObject &jo, const std::string &name, MemberType &member )
 {
     if( jo.has_object( "proportional" ) ) {
@@ -745,9 +742,7 @@ inline bool handle_proportional( const JsonObject &jo, const std::string &name,
 // Dummy template:
 // Warn when trying to use relative when it's not supported, but otherwise,
 // return
-template < typename MemberType,
-           std::enable_if_t < !supports_relative<MemberType>::value > * = nullptr
-           >
+template<typename MemberType> requires( !SupportsRelative<MemberType> )
 inline bool handle_relative( const JsonObject &jo, const std::string &name, MemberType & )
 {
     if( jo.has_object( "relative" ) ) {
@@ -766,7 +761,7 @@ inline bool handle_relative( const JsonObject &jo, const std::string &name, Memb
 // Copy-from makes it so the thing we're inheriting from is used to construct
 // this, so member will contain the value of the thing we inherit from
 // So, check if there is a relative entry, then add it to our member
-template<typename MemberType, std::enable_if_t<supports_relative<MemberType>::value>* = nullptr>
+template<SupportsRelative MemberType>
 inline bool handle_relative( const JsonObject &jo, const std::string &name, MemberType &member )
 {
     if( jo.has_object( "relative" ) ) {
@@ -809,8 +804,8 @@ words: `MemberType foo( ReaderType(...) );` does not work. This is what `is_cons
 If the 5. parameter can be used to construct a `MemberType`, it is assumed to be the default value,
 otherwise it is assumed to be the reader.
 */
-template<typename MemberType, typename DefaultType = MemberType,
-         typename = typename std::enable_if<std::is_constructible<MemberType, const DefaultType &>::value>::type>
+template<typename MemberType, typename DefaultType = MemberType>
+requires( std::is_constructible_v<MemberType, const DefaultType &> )
 inline void optional( const JsonObject &jo, const bool was_loaded, const std::string &name,
                       MemberType &member, const DefaultType &default_value )
 {
@@ -821,9 +816,9 @@ inline void optional( const JsonObject &jo, const bool was_loaded, const std::st
         }
     }
 }
-template < typename MemberType, typename ReaderType, typename DefaultType = MemberType,
-           typename = typename std::enable_if <
-               !std::is_constructible<MemberType, const ReaderType &>::value >::type >
+
+template<typename MemberType, typename ReaderType, typename DefaultType = MemberType>
+requires( !std::is_constructible_v<MemberType, const ReaderType &> )
 inline void optional( const JsonObject &jo, const bool was_loaded, const std::string &name,
                       MemberType &member, const ReaderType &reader )
 {
@@ -833,6 +828,7 @@ inline void optional( const JsonObject &jo, const bool was_loaded, const std::st
         }
     }
 }
+
 template<typename MemberType, typename ReaderType, typename DefaultType = MemberType>
 inline void optional( const JsonObject &jo, const bool was_loaded, const std::string &name,
                       MemberType &member, const ReaderType &reader, const DefaultType &default_value )
diff --git a/src/generic_readers.h b/src/generic_readers.h
index 4f5948fdc3b8..e7ac43a242e3 100644
--- a/src/generic_readers.h
+++ b/src/generic_readers.h
@@ -32,6 +32,8 @@ struct supports_relative<bool> : std::false_type {};
 template<>
 struct supports_relative<std::string> : std::false_type {};
 
+template<typename T> concept SupportsRelative = supports_relative<T>::value;
+
 namespace reader_detail
 {
 template<typename T>
@@ -39,6 +41,10 @@ struct handler {
     static constexpr bool is_container = false;
 };
 
+template<typename T> concept Container = handler<T>::is_container;
+
+template<typename T> concept RelativeContainer = Container<T> &&SupportsRelative<T>;
+
 template<typename T>
 struct handler<std::set<T>> {
     void clear( std::set<T> &container ) const {
@@ -237,10 +243,7 @@ class generic_typed_reader
          * whereas these are reading values of the same type.
          */
         // Type does not support relative
-        template < typename C, typename std::enable_if < !reader_detail::handler<C>::is_container,
-                   int >::type = 0,
-                   std::enable_if_t < !supports_relative<C>::value > * = nullptr
-                   >
+        template<typename C> requires( !reader_detail::Container<C> || !SupportsRelative<C> )
         bool do_relative( const JsonObject &jo, const std::string &name, C & ) const {
             if( jo.has_object( "relative" ) ) {
                 JsonObject relative = jo.get_object( "relative" );
@@ -254,8 +257,7 @@ class generic_typed_reader
         }
 
         // Type supports relative
-        template < typename C, typename std::enable_if < !reader_detail::handler<C>::is_container,
-                   int >::type = 0, std::enable_if_t<supports_relative<C>::value> * = nullptr >
+        template<reader_detail::RelativeContainer C>
         bool do_relative( const JsonObject &jo, const std::string &name, C &member ) const {
             if( jo.has_object( "relative" ) ) {
                 JsonObject relative = jo.get_object( "relative" );
@@ -287,8 +289,7 @@ class generic_typed_reader
          */
         // was_loaded is ignored here, if the value is not found in JSON, report to
         // the caller, which will take action on their own.
-        template < typename C, typename std::enable_if < !reader_detail::handler<C>::is_container,
-                   int >::type = 0 >
+        template<typename C> requires( !reader_detail::Container<C> )
         bool operator()( const JsonObject &jo, const std::string &member_name,
                          C &member, bool /*was_loaded*/ ) const {
             return read_normal( jo, member_name, member ) ||
diff --git a/src/numeric_interval.h b/src/numeric_interval.h
index a7e463b2d064..a89b6a69f20e 100644
--- a/src/numeric_interval.h
+++ b/src/numeric_interval.h
@@ -5,11 +5,13 @@
 #include <limits>
 #include <type_traits>
 
+#include "concepts_utility.h"
+
 /**
  * An interval of numeric values between @ref min and @ref max (including both).
  * By default it's [0, 0].
  */
-template<typename T, typename = typename std::enable_if<std::is_arithmetic<T>::value, T>::type>
+template<Arithmetic T>
 struct numeric_interval {
     T min = static_cast<T>( 0 );
     T max = static_cast<T>( 0 );