Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more basic armor items #3221

Merged
merged 2 commits into from
Sep 24, 2023

Conversation

chaosvolt
Copy link
Member

Summary

SUMMARY: Content "Add arming cap, iron and bronze face masks, and bronze version of arm guards"

Purpose of change

This adds a few more armor additions I cooked up recently. Includes a touch of some extra uses for bronze now that I spent some time updating them, but mostly focuses on some armor roles not as easily filled by existing recipes.

Describe the solution

  1. Added arming cap, to fill the classic role of padding under a helm in the same vein the gambeson serves for normal armor. DDA added an item in this vein a while ago so wrote up my own take, using helmet liners and gambesons as a guideline.
  2. Added iron and bronze masks, descriptions give the implication that they can also work as iron-tier and bronze-tier equivalents to the ballistic mask, or for post-apoc vibe. Adds options for protecting the face that can be separately paired with head-only helms.
  3. Added bronze arm guards, flavored the same as the generic metal arm guards. Basically completes the standard array of basic bronze armor that I neglected to add to Medieval and Historic Content way back in the day, since back then I was only thinking about 100% historic gear and not what a cataclysm survivor might be tempted to make if they have access to bronze. The idea that a bronze manica-type item might be useful for more than just adding gladiator professions in the future escaped my mind way back when.
  4. Added recipe for arming cap, same general level and booklearns as gambeson.
  5. Added recipes for battle masks. Iron version is roughly based off the requirements and skill level of makeshift welding mask except one level lower since not incorporating welding goggles into them, while bronze version is a level higher. Both can be learned from the western (Roman cavalry masks) and eastern (Japanese men-yoroi) books, iron version is autolearn while bronze version is booklearn-only.
  6. Added recipe for bronze armguard, modeled after the metal armguard recipe. As with bronze greaves, it can be unlocked in either the western armor book (gladiator manica) or the street fighting book like metal arm guards. Also as with bronze vs iron greaves, requires basic bronzeworking tools.
  7. Added items to relevant itemgroups. Generally arming caps where you'd expect to see gambesons, masks where you see Roman stuff, a sprinkling of bronze arm guards, etc.
  8. Also tweaked the mansion armor collections a bit, with appropriate collections having a chance of spawning an arming cap and/or gambeson.

Describe alternatives you've considered

  1. Putting all these in Medieval Mod Reborn instead of vanilla.
  2. Making the bronze mask autolearn.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested in compiled build.

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Sep 23, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image

wow they look terrifying

@scarf005 scarf005 merged commit a5e79b7 into cataclysmbnteam:upload Sep 24, 2023
14 checks passed
@chaosvolt
Copy link
Member Author

At some point remind me to also add external tileset sprites for them so they don't use the derpy-looking ballistic mask overlay. Probably will glom onto the mask of insight sprites from Arcana as a base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants