Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove chkjson #3247

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Sep 24, 2023

Summary

SUMMARY: Build "Remove obsoleted chkjson"

Purpose of change

  • BN discord had 3 mentions of chkjson (1, 2, 3) in recorded history and all of them was by me
  • cataclysm executable already provides same functionality via --check-mods
  • no workflow file uses chkjson yet build time is wasted on compiling them
  • last commit (except version bump) was 4y ago

Describe the solution

chkjson is kil

Describe alternatives you've considered

screm

Testing

was able to build tiles on my machine

Additional context

i love negative LOC PRs

Footnotes

  1. https://discord.com/channels/830879262763909202/830916451517857894/1148783611823272059

  2. https://discord.com/channels/830879262763909202/830916451517857894/1148940431070081134

  3. https://discord.com/channels/830879262763909202/830916451517857894/1148941056562434069

- BN discord had 3 mentions of chkjson in recorded history and all of them was by me
- cataclysm executable already provides same functionality via `--check-mods`
@scarf005 scarf005 requested a review from chaosvolt September 24, 2023 05:47
@github-actions github-actions bot added the src changes related to source code. label Sep 24, 2023
@scarf005 scarf005 requested a review from olanti-p September 24, 2023 05:49
@scarf005 scarf005 merged commit b09decc into cataclysmbnteam:upload Sep 24, 2023
14 of 16 checks passed
@scarf005 scarf005 deleted the chkjson-is-kil branch September 24, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants