-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show monster immunity in description #3254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaosvolt
reviewed
Sep 24, 2023
scarf005
force-pushed
the
monster-desc
branch
from
September 24, 2023 22:44
075d69b
to
4a56f9f
Compare
chaosvolt
requested changes
Sep 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, hecc. not sure why that happens, will investigate later. |
well, should've used |
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
scarf005
force-pushed
the
monster-desc
branch
from
September 25, 2023 12:42
80ef498
to
be7c558
Compare
chaosvolt
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Compiled and load-tested.
- Spawned in and examine several critters.
- Basic zombies correctly don't even show the immunity line.
- Firefighter zeds show immunity to acid.
- Zombie masters show bio immunity.
- Robots show immunity to cold and bio-hazard.
scarf005
added a commit
to scarf005/Cataclysm-BN
that referenced
this pull request
Sep 28, 2023
* feat: show monster immunity in description * fix: describe bioproof only once Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com> * fix: use describe_flags * perf: use string_view * style: cmake format --------- Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Show monster immunity in extended description"
Purpose of change
expose more info to players, in this PR, immunity
Describe the solution
describe_flags
lambdaCataclysm-BN/src/damage.h
Line 23 in b545f49
Describe alternatives you've considered
name its immunity
biohazard
Testing
Additional context
biohazard
orsmoke
+poison
?smoke
orpoison
damage type?