Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump android ndk #3289

Merged
merged 2 commits into from
Sep 27, 2023
Merged

build: bump android ndk #3289

merged 2 commits into from
Sep 27, 2023

Conversation

scarf005
Copy link
Member

Summary

Bugfixes: "Fixed failing android build caused due to ndk version"

Purpose of change

Describe the solution

@scarf005 @BrettDong
build: bump android ndk
914ba67 
see: CleverRaven/Cataclysm-DDA#64305

Co-authored-by: Brett Dong <brett.browning.dong@gmail.com>
@scarf005 scarf005 force-pushed the fix-android-filesystem branch from 8d134cc to 24e04ac Compare September 27, 2023 09:06
@scarf005 scarf005 force-pushed the fix-android-filesystem branch from 24e04ac to bec53c7 Compare September 27, 2023 09:34
Firestorm01X2
Firestorm01X2 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@Firestorm01X2 Firestorm01X2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix

@Firestorm01X2 Firestorm01X2 added this pull request to the merge queue Sep 27, 2023
Merged via the queue into cataclysmbnteam:upload with commit 8f34053 Sep 27, 2023
11 checks passed
scarf005 added a commit to scarf005/Cataclysm-BN that referenced this pull request Sep 28, 2023
@scarf005 @BrettDong
build: bump android ndk (cataclysmbnteam#3289)
7fabe71 
* build: bump android ndk

see: CleverRaven/Cataclysm-DDA#64305

Co-authored-by: Brett Dong <brett.browning.dong@gmail.com>

* ci: bump jdk version to 11

---------

Co-authored-by: Brett Dong <brett.browning.dong@gmail.com>
This was referenced Oct 8, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Firestorm01X2 Firestorm01X2 Firestorm01X2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

android build failure after inclusion of std::filesystem
2 participants
@scarf005 @Firestorm01X2