Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Repair Nanobots #3308

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Conversation

KheirFerrum
Copy link
Collaborator

@KheirFerrum KheirFerrum commented Sep 29, 2023

Summary

SUMMARY: Bugfixes "Fix Repair Nanobots"

Purpose of change

Describe the solution

Add back code that marks limbs for repair, keep mending parts out of it.

Describe alternatives you've considered

Reworking Nanobots for the nth time to do new and weird things.

Testing

Spawned character, damaged torso and one limb to 60 HP. Added self-aware mutation to track HP.
Installed Repair Nanobots, added 100 kJ power.

  • Wait one hour, check that no healing and power draw is observed.
  • Turn on Repair Nanobots, check that body parts heal and power draw is as expected.

Additional context

@github-actions github-actions bot added the src changes related to source code. label Sep 29, 2023
@scarf005 scarf005 self-assigned this Sep 29, 2023
@scarf005
Copy link
Member

scarf005 commented Sep 29, 2023

would it be possible to also write a test for it? (to prevent furthur changes breaking repair nanobots from working)?

related: #3306

@KheirFerrum
Copy link
Collaborator Author

KheirFerrum commented Sep 29, 2023

would it be possible to also write a test for it? (to prevent furthur changes breaking repair nanobots from working)?

related: #3306

Don't know. I don't typically write tests and thus would have to look it over first.

Edit: Would prefer that this be merged before 0.4 stable goes out though.

@scarf005 scarf005 requested a review from chaosvolt September 29, 2023 11:56
@scarf005 scarf005 removed their assignment Sep 29, 2023
@scarf005
Copy link
Member

alright. it's late here, will ask for @chaosvolt for reviewing.

@olanti-p olanti-p added this pull request to the merge queue Sep 29, 2023
Merged via the queue into cataclysmbnteam:upload with commit 88924ca Sep 29, 2023
13 of 14 checks passed
@KheirFerrum KheirFerrum deleted the Nanobot-fix branch September 29, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants