Fix tidy warnings #3310
Merged
Fix tidy warnings #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
src
olanti-p
force-pushed
the
fix-tidy-warnings
branch
from
53c71e8 to
d4ae6dd
Compare
olanti-p
force-pushed
the
fix-tidy-warnings
branch
from
b26cfe6 to
ea8a778
Compare
scarf005
approved these changes
Sep 30, 2023
Merged
via the queue into
cataclysmbnteam:upload
with commit Sep 30, 2023
1fbcf35
33 of 42 checks passed
olanti-p
added a commit
to olanti-p/Cataclysm-BN
that referenced
this pull request
Oct 6, 2023
* Fix all warnings that show up for problem matcher * Promote warnings to errors * Remove unused statics * Fix unneeded static usage * Silence cata-no-long in explosion animation code * Fix instance of readability-const-return-type * Fix named constants usage * Fix more unused statics * Fix parameter name * Fix float division * Fix use after move * Fix unused static * Silence point lints in mapgen point math * Fix named point constant in mapgen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Build "Fixed clang-tidy warnings"
Purpose of change
Closes #2629
Describe the solution
Promote warnings to errors, so tidy does not always report a green check.
Fix resulting warnings, or silence them in some cases.
Testing
Will be done by Github Actions