Voltmeter & pH meter rebalancing #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can put the voltmeter on your toolbelt
scarf005
previously approved these changes
Sep 30, 2023
Whoops I should've tried it with the toolbelt and not my modded holsters. We should add XL toolbelts in another PR with greater encumbrance and storage. |
See discussion in discord about why this size is reasonable.
|
@scarf005 As per @chaosvolt suggestions, the voltmeter is more realistically sized at 500 grams 750 mL I have made said change and I will update PR description. |
RoyalFox2140
changed the title
chaosvolt
approved these changes
Sep 30, 2023
Merged
via the queue into
cataclysmbnteam:upload
with commit Sep 30, 2023
2202dc2
9 of 12 checks passed
olanti-p
pushed a commit
to olanti-p/Cataclysm-BN
that referenced
this pull request
Oct 6, 2023
* voltmeter on toolbelt You can put the voltmeter on your toolbelt * realistic voltmeter size See discussion in discord about why this size is reasonable. * Update science.json --------- Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: [Balance] "Voltmeter & pH rebalancing"
Purpose of change
Voltmeters are much smaller IRL and I think it belongs on a toolbelt. I added the "BELT_CLIP" flag so it can be put on a toolbelt so it won't be lost easily. I also toned down its size and weight to suggestions on the discord. pH meters are also much smaller IRL, and it was suggested by Chaosvolt to change that in the same PR as well.
Describe the solution
I added the "BELT_CLIP" flag. It can now be on a toolbelt. Also, it is 500 grams 750mL as real life examples follow this size.
Chaosvolt changed the pH meter stats to also be more reflective of the real world.
Describe alternatives you've considered
Losing my voltmeter in a lake.
Testing
Loaded game, game worked. Voltmeter can be placed in toolbelt. It works.
Additional context