Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency updates for street light placement #3369

Merged

Conversation

chaosvolt
Copy link
Member

Summary

SUMMARY: Balance "Place street lights in areas previously updated to be more consistent"

Purpose of change

Some follow-up updates to #3265 because since then I've gone and set an actual precedent for where the street lights should be placed relative to the street and some of those locations I initially updated kinda don't follow that new convention. XD

Describe the solution

  1. Added a streetlight on the right side to malls at the road connection. Kept the parking lot lights unchanged since is a big location.
  2. Moved the street lights in banks over to the right side.
  3. Set public space to have just one light over on the right.
  4. Shifted placement of street lights in home improvement stores.
  5. Updated parking lot placement of street lights in hospitals.
  6. Adjusted placement of street light in those janky fucking megastore parking lots.
  7. Added street light to motels in the new standard spots, as with malls left the parking lot lights intact since why not.
  8. Added street lights in the expected road connections to football stadiums, leaving the original lights in place for effect.
  9. Updated light placement at town hall.
  10. Misc: Fixed football stadium not having a pole on the opposite end of the field.

Left abandoned shopping plaza unchanged as the edge is occupied wholly by the chain-link fence. Bus station placement also seemed close enough that it'd still look right.

Describe alternatives you've considered

Screaming.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested to make sure I didn't miss an undefined tile.

Additional context

At some point football stadiums need some tweaks so that it'll be possible to grant them lighting. main thing is the lines of grass are oddly placed and a bit uneven.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Oct 5, 2023
Swear on yer fuckin yeezies
@olanti-p
Copy link
Contributor

olanti-p commented Oct 7, 2023

Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3348 (comment)

could you also check gym mapgen?

data/json/mapgen/gym.json Show resolved Hide resolved
@github-actions github-actions bot added the mods PR changes related to mods. label Oct 7, 2023
@chaosvolt
Copy link
Member Author

Whoops, just woke up and overlooked that D:

@olanti-p olanti-p enabled auto-merge October 7, 2023 20:06
@olanti-p olanti-p added this pull request to the merge queue Oct 7, 2023
Merged via the queue into cataclysmbnteam:upload with commit 7b1b1da Oct 7, 2023
12 checks passed
@chaosvolt chaosvolt deleted the street-light-followup-revisit branch October 7, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants