-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency updates for street light placement #3369
Merged
olanti-p
merged 5 commits into
cataclysmbnteam:upload
from
chaosvolt:street-light-followup-revisit
Oct 7, 2023
Merged
Consistency updates for street light placement #3369
olanti-p
merged 5 commits into
cataclysmbnteam:upload
from
chaosvolt:street-light-followup-revisit
Oct 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swear on yer fuckin yeezies
scarf005
reviewed
Oct 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also check gym mapgen?
scarf005
requested changes
Oct 7, 2023
Whoops, just woke up and overlooked that D: |
olanti-p
approved these changes
Oct 7, 2023
scarf005
approved these changes
Oct 7, 2023
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "Place street lights in areas previously updated to be more consistent"
Purpose of change
Some follow-up updates to #3265 because since then I've gone and set an actual precedent for where the street lights should be placed relative to the street and some of those locations I initially updated kinda don't follow that new convention. XD
Describe the solution
Left abandoned shopping plaza unchanged as the edge is occupied wholly by the chain-link fence. Bus station placement also seemed close enough that it'd still look right.
Describe alternatives you've considered
Screaming.
Testing
Additional context
At some point football stadiums need some tweaks so that it'll be possible to grant them lighting. main thing is the lines of grass are oddly placed and a bit uneven.