-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mods/DinoMod): Fix Dinomod overwriting various egg-based food recipes #4085
Conversation
This is why you don't forget to use id_suffix
The Autofix app has found code style violation and automatically formatted this Pull Request. I locally edit my commits (e.g: git, github desktop)Please choose following options: I'd like to accept the automated commit
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. This PR is complete and I don't want to edit it anymoreIt's safe to ignore this message. I edit this PR through web UIYou can ignore this message and continue working. I have no idea what this message is talking aboutYou can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
birb
Birb indeed |
Side note, semantic PR title still confounds me. |
As it does me. I'll just generally try and get it roughly correct and call it good enough whenever I make a PR |
i think it fails because the check is case senstive. |
Purpose of change
Fixes an issue occurring regarding Dinomod overwriting the egg-based food recipes to only use dinomod eggs.
Describe the solution
Adds an appropriate id_suffix to the relevant recipes.
Also removes the random extra powdered egg recipes that just had a slight time difference and the ability to use surface_heat, just for the sake of making sure they aren't overwriting anything (though those might have been the intended proper recipes)
Describe alternatives you've considered
Leaving those tasty bird and other egg types unable to be cooked
Instead removing the other pair of powdered egg recipes, and keeping the ones with surface_heat
I just have no clue what the purpose of the ones with surface_heat was, and thus I chose to keep the ones consistent with vanilla.
Testing
Loaded in, confirmed that everything was working
Additional context
Down with the dino-egg monopoly on egg items!