Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mods/DinoMod): Fix Dinomod overwriting various egg-based food recipes #4085

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

RobbieNeko
Copy link
Contributor

Purpose of change

Fixes an issue occurring regarding Dinomod overwriting the egg-based food recipes to only use dinomod eggs.

Describe the solution

Adds an appropriate id_suffix to the relevant recipes.
Also removes the random extra powdered egg recipes that just had a slight time difference and the ability to use surface_heat, just for the sake of making sure they aren't overwriting anything (though those might have been the intended proper recipes)

Describe alternatives you've considered

  • Leaving those tasty bird and other egg types unable to be cooked

  • Instead removing the other pair of powdered egg recipes, and keeping the ones with surface_heat
    I just have no clue what the purpose of the ones with surface_heat was, and thus I chose to keep the ones consistent with vanilla.

Testing

Loaded in, confirmed that everything was working

Additional context

Down with the dino-egg monopoly on egg items!

image

This is why you don't forget to use id_suffix
@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels Jan 9, 2024
@RobbieNeko RobbieNeko changed the title fix(mods/Dinomod) Fix Dinomod overwriting various egg-based food recipes fix(mods/Dinomod): Fix Dinomod overwriting various egg-based food recipes Jan 9, 2024
Copy link
Contributor

autofix-ci bot commented Jan 9, 2024

The Autofix app has found code style violation and automatically formatted this Pull Request.

I locally edit my commits (e.g: git, github desktop)

Please choose following options:

I'd like to accept the automated commit
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

This PR is complete and I don't want to edit it anymore

It's safe to ignore this message.

I edit this PR through web UI

You can ignore this message and continue working.

I have no idea what this message is talking about

You can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005.

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

birb

@RobbieNeko
Copy link
Contributor Author

Birb indeed

@chaosvolt
Copy link
Member

Side note, semantic PR title still confounds me.

@RobbieNeko
Copy link
Contributor Author

RobbieNeko commented Jan 9, 2024

Side note, semantic PR title still confounds me.

As it does me. I'll just generally try and get it roughly correct and call it good enough whenever I make a PR

@scarf005
Copy link
Member

scarf005 commented Jan 9, 2024

i think it fails because the check is case senstive.

@scarf005 scarf005 changed the title fix(mods/Dinomod): Fix Dinomod overwriting various egg-based food recipes fix(mods/DinoMod): Fix Dinomod overwriting various egg-based food recipes Jan 9, 2024
@scarf005 scarf005 merged commit 63166e6 into cataclysmbnteam:main Jan 10, 2024
9 checks passed
@chaosvolt
Copy link
Member

Also, yee
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants