Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: interior pickable metal doors can now pick on examine #4096

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

chaosvolt
Copy link
Member

Purpose of change

This fixes examining interior pickable metal doors not automatically lockpicking like they're supposed to. They worked just fine on manually activating a lockpick, but not on examine.

Turns out the problem is examine_action doesn't inherit right. Also found out that it needs to inherit lockpick_message too.

Describe the solution

Adds lockpick_message and examine_action to pickable interior doors.

Describe alternatives you've considered

Finding the inheritance code responsible for this and figuring out how to add proper inheritance for those things? Not sure where to look for that and this is faster so.

Testing

  1. Checked affected file for syntax and lint errors.
  2. Ported JSON change to playthrough build.
  3. Can now pick open the military outpost doors I was previously unable to, and correct message prints.

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 11, 2024
@scarf005 scarf005 merged commit 8cbed5f into cataclysmbnteam:main Jan 12, 2024
9 checks passed
@chaosvolt chaosvolt deleted the doors-are-made-of-screm branch January 12, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants