-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(balance): Phase out some redundant bionics, add bionic infolink #4106
feat(balance): Phase out some redundant bionics, add bionic infolink #4106
Conversation
The rest is good but can we please keep the tattoo? I like having it for RP reasons. |
Pain. Between that and possible plans to rework the water extractor into something that purifies water en mass, I might I guess undo the obsoletion of water extractor and LED tattoo I guess weh XD |
No reason to hold up the PR because I have longterm plans to do something with the water extractor. If its just in obsolete.json it can be resurrected as fast as it was killed. LED tattoo is its own story and I already commented that we work with ascii and 32x32 so you can't meaningfully represent such sprites on the character, a tattoo system in general is menu text if it doesn't glow enough to be useful. |
Auuuugh make your minds weh. I'm gonna just make the LED tattoo bright enough to ensure it actually lets you craft and unobsolete it, plus not like it really hurts to have it in weh XD |
…osvolt/Cataclysm-BN into bionic-merges-and-obsoletion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging multiple small CBMs into one sounds like a good QoL improvement.
Man, I come back and you've obsoleted one of the best bionics. Directional EMP was good because it was a melee attack and couldn't miss if you ended up in melee with a robot. |
Purpose of change
This does a bit of work towards phasing out a couple of completely redundant and pointless bionics, improving underwhelming ones, and/or packaging some functions that could reasonably be combined. Goal is reducing a few cases where a bionic is in some way not worth the hassle of installing.
Describe the solution
C++ changes:
bio_watch
andbio_infolink
in avatar.cpp, bionics.cpp, character.cpp, panels.cpp, player_hardcoded_effect.cpp, and sounds.cpp to refer to a new bionic as mentioned below that replaces both internal chronometer and weather reader...JSON changes:
Describe alternatives you've considered
I was originally gonna obsolete the LED tattoo and water extractor CBMs, but got talked into rebalancing the LED tats a bit to be more actually worth using, and talked into keeping extractor for now because it'll make it less hassle to convert it to be less fucking weird like it currently is.
Testing
Additional context
I've already got another idea for a bionic to add (an electroreception CBM that will combine the utility of the Electoreceptor mutation, a bionic scanner, and a voltmeter) but figuring out how to code that one seems complex enough I'd rather save it for later.
Checklist