Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separate house22 variants #4117

Merged
merged 5 commits into from
Jan 17, 2024
Merged

fix: separate house22 variants #4117

merged 5 commits into from
Jan 17, 2024

Conversation

0Monet
Copy link
Contributor

@0Monet 0Monet commented Jan 17, 2024

Purpose of change

Fix because the two uninhabited house22 variants (after the normal variant) don't have stairs down to the basement below their mapgen.
This results in an inaccessible basement below.

Describe the solution

Separate the uninhabited house22 variants.

Describe alternatives you've considered

house22 variants have not been fixed in cdda, so no port.
Put a stair in the variants, but the basement wouldn't fit because it's not empty.

Testing

  1. Check JSON for errors.
  2. Start a new game and no errors.
  3. Nothing more.

Additional context

nothing

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 17, 2024
Copy link
Contributor

autofix-ci bot commented Jan 17, 2024

The Autofix app has found code style violation and automatically formatted this Pull Request.

I locally edit my commits (e.g: git, github desktop)

Please choose following options:

I'd like to accept the automated commit
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

This PR is complete and I don't want to edit it anymore

It's safe to ignore this message.

I edit this PR through web UI

You can ignore this message and continue working.

I have no idea what this message is talking about

You can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005.

@Firestorm01X2 Firestorm01X2 merged commit b7b43e5 into cataclysmbnteam:main Jan 17, 2024
9 checks passed
@0Monet 0Monet deleted the fix-house22 branch January 17, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants