-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add info for mutation enchantments #4118
docs: add info for mutation enchantments #4118
Conversation
The Autofix app has found code style violation and automatically formatted this Pull Request. I locally edit my commits (e.g: git, github desktop)Please choose following options: I'd like to accept the automated commit
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. This PR is complete and I don't want to edit it anymoreIt's safe to ignore this message. I edit this PR through web UIYou can ignore this message and continue working. I have no idea what this message is talking aboutYou can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005. |
doc/src/content/docs/en/mod/json/reference/creatures/effects_json.md
Outdated
Show resolved
Hide resolved
A note to onlookers that want to change the docs, don't assume because you're in an IME that it will be formatted on the web page. Use |
I hate that tackling a change request comment will correctly reseolve the associated conversation but doesn't dismiss the linked review weh >:C
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be gud :>
dismissing existing reviews doesn't do anything, approving does. |
Purpose of change
There was poor documentation for adding effects via mutation, I added documentation for doing this with mutation enchantments.
Describe the solution
In json_info.md The field for enchantments is added.
in effects_json.md I gave an in-repo example of a mutation that grants an enchantment, and an example of an enchantment that grants a permanent effect.
Describe alternatives you've considered
Keeping it a mystery because that's funnier. Bugging others.
Testing
It's docs.
Additional context
Pain