Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): fuel briquette #4121

Merged
merged 4 commits into from
Jan 28, 2024
Merged

Conversation

yay855
Copy link
Contributor

@yay855 yay855 commented Jan 18, 2024

Added in fuel briquette, a puck of dried plant matter that's used as firewood.

Purpose of change

Straw and dried plants have very few uses beyond cordage and some innawoods constructions. I decided to give them another.

Describe the solution

Added in fuel briquette, a lump of dried plant matter that burns.

Describe alternatives you've considered

Testing

Additional context

Checklist

Added in fuel briquette, a puck of dried plant matter that's used as firewood.
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 18, 2024
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe would it be possible to make withered plant and straw pile 'rot' into dried fuel?

@yay855
Copy link
Contributor Author

yay855 commented Jan 18, 2024

If you think that's a better idea, I'm all for it.

@chaosvolt
Copy link
Member

I don't think we have support for items rotting into other items, plus withered plants and straw don't rot currently anyway.

Side note, it could also be set to count as charcoal if it was converted to ammo (and its bulkiness tweaked to be more in line with charcoal)

@yay855
Copy link
Contributor Author

yay855 commented Jan 18, 2024

It could, but it's not exactly processed like charcoal, it's literally just dried plants woven into a brick.

@yay855
Copy link
Contributor Author

yay855 commented Jan 18, 2024

I'm also not sure what the point of making charcoal an ammo type would serve.

@RoyalFox2140
Copy link
Collaborator

I should note I don't know what this is useful for given we can burn straw and plants directly and they dont rot at all, but I'm all for processing it to condense item count for less lag and item count in a tile.

@chaosvolt
Copy link
Member

Charcoal is already an ammotype, I meant changing it to ammo of that type so forges, smokers, and the like have a potential non-kiln source of fuel innawods. :>

@RoyalFox2140
Copy link
Collaborator

Charcoal is already an ammotype, I meant changing it to ammo of that type so forges, smokers, and the like have a potential non-kiln source of fuel innawods. :>

Yes then we can use it for steam engines.

@yay855
Copy link
Contributor Author

yay855 commented Jan 18, 2024

I should note I don't know what this is useful for given we can burn straw and plants directly and they dont rot at all, but I'm all for processing it to condense item count for less lag and item count in a tile.

That, and for making it work better with zoning, so you can autosort excess plants into your fuel pile directly.

scarf005
scarf005 previously approved these changes Jan 18, 2024
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

https://github.com/cataclysmbnteam/Cataclysm-BN/actions/runs/7564900282/job/20599773521?pr=4121#step:14:1964

test failure unrelated to PR. why doesn't this get added on problem matcher?

@RoyalFox2140
Copy link
Collaborator

I should note I don't know what this is useful for given we can burn straw and plants directly and they dont rot at all, but I'm all for processing it to condense item count for less lag and item count in a tile.

That, and for making it work better with zoning, so you can autosort excess plants into your fuel pile directly.

Probably also use a custom filter zone to dump piles of straw into your kilns.

@yay855
Copy link
Contributor Author

yay855 commented Jan 18, 2024

Charcoal is already an ammotype, I meant changing it to ammo of that type so forges, smokers, and the like have a potential non-kiln source of fuel innawods. :>

Yes then we can use it for steam engines.

Ohh, perhaps. Though IRL steam engines could run off of just about any wood, but that would make steam engines ingame able to use fuel briquettes. Fair point.

@yay855
Copy link
Contributor Author

yay855 commented Jan 18, 2024

I should note I don't know what this is useful for given we can burn straw and plants directly and they dont rot at all, but I'm all for processing it to condense item count for less lag and item count in a tile.

That, and for making it work better with zoning, so you can autosort excess plants into your fuel pile directly.

Probably also use a custom filter zone to dump piles of straw into your kilns.

I suppose. Though the condensing is still useful.

@scarf005
Copy link
Member

I should note I don't know what this is useful for given we can burn straw and plants directly and they dont rot at all, but I'm all for processing it to condense item count for less lag and item count in a tile.

for condensing item count, i think making it stackable would be better (or is it already?)

@NappingOcean
Copy link
Contributor

Is the Bash 18 for this item intended? That seems like a high value for any weapon.
If the item is not hard enough and breaks easily when wielded as a weapon, consider adding a FRAGILE_MELEE flag.

@chaosvolt
Copy link
Member

Yeah it might be better off toning down overall bulk and other stats, I'll have to look at it in the morning I guess.

@yay855
Copy link
Contributor Author

yay855 commented Jan 18, 2024

The bash 18 was unintentional, I forgot to remove it when I copied the code of a different item. As for the bulk, it's exactly as large as the input materials.

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as is, it being usable as charcoal would be neat too but can always mess with another time.

@scarf005 scarf005 merged commit bae45a1 into cataclysmbnteam:main Jan 28, 2024
9 checks passed
@yay855 yay855 deleted the fuel_briquette branch January 28, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants