Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pick_safe_adjacent_tile returning invalid position #4138

Merged
merged 1 commit into from
Jan 20, 2024
Merged

fix: pick_safe_adjacent_tile returning invalid position #4138

merged 1 commit into from
Jan 20, 2024

Conversation

scarf005
Copy link
Member

Purpose of change

Describe the solution

return std::nullopt instead of default initialized value

Describe alternatives you've considered

RIIR

Testing

worked in my machine

Additional context

prerequisite for patches i'm making in #4125

@github-actions github-actions bot added the src changes related to source code. label Jan 20, 2024
@scarf005 scarf005 enabled auto-merge (squash) January 20, 2024 08:18
@scarf005 scarf005 merged commit b625f1f into cataclysmbnteam:main Jan 20, 2024
12 checks passed
@scarf005 scarf005 deleted the fix-pick_safe_adjacent_tile branch January 20, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joveeater joveeater joveeater approved these changes

Assignees
No one assigned
Labels
src changes related to source code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

character_funcs::pick_safe_adjacent_tile returns invalid position instead of failing
2 participants
@scarf005 @joveeater