Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): Solar power bump #4155

Merged
merged 9 commits into from
Feb 4, 2024

Conversation

yay855
Copy link
Contributor

@yay855 yay855 commented Jan 24, 2024

Made regular solar panels generate 80 power instead of 50 and advanced solar panels generate 160 instead of 100.

Purpose of change

Solar panels are rather weak ingame currently, and struggle to properly recharge vehicles and power grids.

Describe the solution

The power generation of all solar panels will be increased by roughly 60%.

Describe alternatives you've considered

Reimplementing quantum solar panels.

Testing

Additional context

Checklist

Made regular solar panels generate 100 power instead of 50 and advanced solar panels generate 200 instead of 100.
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 24, 2024
@yay855
Copy link
Contributor Author

yay855 commented Jan 24, 2024

I have no idea why this doesn't work, can someone please help?

@yay855 yay855 changed the title Solar power bump feat(balance): Solar power bump Jan 24, 2024
@github-actions github-actions bot added the tests changes related to tests label Jan 24, 2024
@RoyalFox2140
Copy link
Collaborator

I have no idea what power units this game is in since 80 is an arbitrary number, but some real world data:

So the average commercial solar panel is 1.75m x 1.03m and is a 500 watt panel. Given advancements of course that will go up and we set BN in the future. We can calculate the power per meter squared from this if we want. Though it's also worth mentioning nothing is in it's proper wattage including refrigerators. The whole grid system is arbitrary.

https://www.solarreviews.com/blog/500-watt-solar-panels
https://www.cleanenergyreviews.info/blog/most-powerful-solar-panels

@yay855
Copy link
Contributor Author

yay855 commented Jan 24, 2024

That's a good idea, but I'm too burnt out today to figure that out. Maybe tomorrow.

Copy link
Contributor

autofix-ci bot commented Jan 24, 2024

The Autofix app has found code style violation and automatically formatted this Pull Request.

I locally edit my commits (e.g: git, github desktop)

Please choose following options:

I'd like to accept the automated commit
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

This PR is complete and I don't want to edit it anymore

It's safe to ignore this message.

I edit this PR through web UI

You can ignore this message and continue working.

I have no idea what this message is talking about

You can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005.

@Zireael07
Copy link
Contributor

I remember a similar discussion either here or on CDDA repo with links to insolation maps and panel power outputs...

@chaosvolt
Copy link
Member

I hate the vehicle power tests I swear XD

@scarf005 scarf005 merged commit 1ab6c23 into cataclysmbnteam:main Feb 4, 2024
11 checks passed
@yay855 yay855 deleted the solar-panel-buff branch February 4, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. tests changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants