-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content): weapon mount obsoletion, part 1 #4179
Conversation
Removed all basegame weapon mount mod slots, replacing them with the corresponding mod slots of that type.
Removed weapon mount mod locations from modded weapons, replacing them with corresponding weapon mod locations.
The Autofix app has found code style violation and automatically formatted this Pull Request. I locally edit my commits (e.g: git, github desktop)Please choose following options: I'd like to accept the automated commit
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. This PR is complete and I don't want to edit it anymoreIt's safe to ignore this message. I edit this PR through web UIYou can ignore this message and continue working. I have no idea what this message is talking aboutYou can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005. |
Modified ranged burst balance test via RoyalFox's recommendation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay so the one entire concern with this PR was what happened to the tests. Removing underbarrel_mount from the tests didn't invalidate them which means the mount does NOTHING besides add 10 grams of weight to a gun.
That means that if this is actually an egregious balance change it's solvable by adding said 10 grams of weight, but importantly, this does not affect gun stats or the tests would still be failing. There won't be unforeseen consequences here unless the tests failed to account for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of guns are affected by this, some of them we may wish to remove gunmod slots from later on, but the basic idea seems to be okay I guess. Mount slots seem to cause a lot of player confusion and I don't think I've seen any big pushback from others so far so hopefully this is aight.
I'm approving this but I may wish to ask for @scarf005 and especially @Coolthulhu to give their quick-and-dirty opinion on if they're okay with it too.
Realized I don't actually need to wait for cataclysmbnteam/Cataclysm-BN#4179 to be merged, nothing in this is dependent on it so. :3
Purpose of change
Weapon mod mounts are a tedious and annoying mechanic, requiring you to craft a weapon mod to attach to a weapon in order to attach weapon mods to that weapon.
Describe the solution
All instances of weapon mod mounts in weapons have been replaced with a corresponding weapon mod. So for example, all stock mounts have been replaced with regular stock slots.
Furthermore, the weapon mod mount recipes have been obsoleted, and the weapon mod mount items have been moved to the obsolete folder.
Describe alternatives you've considered
We could make weapon mount mods easier to install, instead.
Testing
The json seems to have no errors, and given that it's a fairly simple change, it shouldn't spawn any errors
Additional context
Checklist