Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: description and id of t_thconc_floor_nofloor #4203

Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix: description and id of t_thconc_floor_nofloor #4203

merged 2 commits into from
Feb 9, 2024

Conversation

0Monet
Copy link
Contributor

@0Monet 0Monet commented Feb 8, 2024

Purpose of change

Redo #3891.
Change description and id of t_thconc_floor_nofloor.

Describe the solution

Remove t_thconc_floor_nofloor from acidia_commercial_destroyed_palette.json
Create t_thconc_floor_no_roof with t_thconc_floor_nofloor as "alias" in terrain-floors-outdoors.json

Describe alternatives you've considered

Change only the description.

Testing

  1. Took a save file made before these changes.
  2. Load the save file in another game, which contains these changes in the JSON.
  3. No errors.

Additional context

none

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 8, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that the alias works as intended in old saves with the old terrain kicking around, seems to be all good.

@scarf005
Copy link
Member

scarf005 commented Feb 9, 2024

merging as the tests all pass.

@scarf005 scarf005 merged commit 66f6985 into cataclysmbnteam:main Feb 9, 2024
10 checks passed
@0Monet 0Monet deleted the redo-fix_floor_nofloor branch February 21, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants