fix: don't assign piercing damage to weapons that were previously cutting #4217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
So, #4214 was implemented by a script that accidentally converted some polearms from cutting damage to piercing damage.
In addition, mods folder wasn't touched by that PR.
Describe the solution
SPEAR
flag on them for now.SPEAR
flag to naginata fake because the other variants have it. How the fuck the automation script missed that when the item is basically identical to the other two flag-wise is beyond me.STAB
flag for items that don't needSPEAR
#4212. SwappedSPEAR
forSTAB
for stirge proboscis, demon spider fang, barbed javelin, TEST sonic screwdriver, and TEST soldering iron4, Additionally added
STAB
flag to fix Biomancer spear, Wicked Bonespear, and wood trident.Describe alternatives you've considered
SPEAR
flag or not, and if so whether halberds are still too bulky to justify it, but I left things as they are for now and just fixed the actual mistakes.Testing
Additional context
Checklist