Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(port): cache NPC goal #4225

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

End3r991
Copy link
Contributor

Purpose of change

One of the PR ported for #3073.

Describe the solution

Describe alternatives you've considered

Testing

Additional context

Source PR: Performance: Cache NPC goal, by @dseguin: CleverRaven/Cataclysm-DDA#54312

Checklist

@github-actions github-actions bot added the src changes related to source code. label Feb 12, 2024
@chaosvolt chaosvolt changed the title Performance(port): Cache NPC goal Feat(performance, port): Cache NPC goal Feb 13, 2024
@chaosvolt chaosvolt changed the title Feat(performance, port): Cache NPC goal Feat(performance, port): cache NPC goal Feb 13, 2024
@End3r991 End3r991 changed the title Feat(performance, port): cache NPC goal perf(port): cache NPC goal Feb 13, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:
1

After:
2

It compiles and tests past, variation is really too small to say what it's doing. Might need to spawn a fuckload of dynamic NPCs instead I assume, instead of testing refugee center? I dunno.

@scarf005
Copy link
Member

commits are missing co-authors despite being ported from DDA. could we attribute the original authors with this?

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

@chaosvolt
Copy link
Member

Worth a try yeah. Last time I checked their branch out and amended last commit, and it instead created a new commit with the crediting added...

End3r991 and others added 2 commits February 15, 2024 00:03
Co-authored-by: David Seguin <davidseguin@live.ca>
Co-authored-by: David Seguin <davidseguin@live.ca>
@scarf005 scarf005 merged commit 8946731 into cataclysmbnteam:main Feb 14, 2024
13 checks passed
@scarf005
Copy link
Member

scarf005 commented Feb 14, 2024

image
(left: before, right: after)

command used: perf record -e 'cpu-cycles:u' -ag -- sleep 10

i guess the performance got improved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants