Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing looks_like #4245

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

mythosmod
Copy link
Contributor

@mythosmod mythosmod commented Feb 21, 2024

Purpose of change

Adds looks_like to the requested items, resolve #3995

Describe the solution

Covers:

  • the whole terrain section
  • the whole furniture section
  • the whole item section

Describe alternatives you've considered

Leaving items as they are with ascii characters

Testing

Changes loaded into base game and tested - debug log coming back as expected.

New missing items not on original list:

  • sake
  • brew_sake
  • sikhye
  • rice_bran

Additional context

22:07:16.218 INFO : Loaded tileset: UNDEAD_PEOPLE_BASE
22:07:48.807 INFO : Loaded tileset: UNDEAD_PEOPLE_BASE
22:07:48.815 INFO : Missing terrain: 
22:07:48.815 INFO : Missing terrain (but looks_like tile exists): t_door_metal_interior_locked t_grate_indoor t_bog_iron t_clay_bog t_strconc_floor_no_roof t_orifice t_elevator_no_roof t_deck_coating_no_roof t_deck_coating_no_roof_y t_deck_coating_no_roof_r t_deck_coating_no_roof_w t_thconc_y_no_roof t_thconc_floor_no_roof t_elevator_control_no_roof t_elevator_control_off_no_roof t_web_bridge t_railroad_track_ramp_down_high t_railroad_track_ramp_down_low t_railroad_track_ramp_up_high t_railroad_track_ramp_up_low 
22:07:48.816 INFO : Missing furniture: 
22:07:48.816 INFO : Missing furniture (but looks_like tile exists): f_floor_lamp_off f_glass_fridge_off f_glass_fridge_on f_glass_freezer_off f_glass_freezer f_glass_freezer_on f_rvoven f_solar_unit_v2 f_battery_large f_battery_huge f_battery_small f_battery_car f_battery_motorbike f_battery_motorbike_small f_recharge_station f_welderrig f_forgerig f_craftrig f_chemistry_set f_chemlab f_gridsolderingiron f_fridge_off f_fridge_on f_freezer_off f_freezer f_freezer_on f_minifreezer_off f_minifreezer f_minifreezer_on f_gridautoclave f_space_heater f_space_heater_off f_space_heater_on f_space_heater_large f_space_heater_large_off f_space_heater_large_on f_grid_plut_generator f_alien_scar_small f_debug_pump f_water_dispenser f_organ f_triple_bunkbed f_cardboard_floor f_cardboard_roof f_cardboard_door_o f_cardboard_door f_console_broken_table f_console_table f_rope_up_web f_file_cabinet 
22:07:48.822 INFO : Missing item: sake brew_sake sikhye rice_bran 

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 21, 2024
@scarf005 scarf005 changed the title chore: Add looks_like based on lists in #3995 chore: Add missing looks_like Feb 21, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:3

@chaosvolt chaosvolt merged commit 24a73c5 into cataclysmbnteam:main Feb 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

☂️ add missing looks_like
2 participants