fix: check for valid seed before reference in can_do_activity_there()
#4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can add the phrase |
scarf005
changed the title
can_do_activity_there()
Good point, I'll keep it in mind for the future. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Fix segfault introduced in ba60edc when attempting to make a farmplot zone of "No Seed" and then trying to farm said plot using automatic actions via "O"->"m".
Describe the solution
Check for valid seed object before referencing it.
Describe alternatives you've considered
Testing
Repro'd the crash based on instructions in bug ticket #4243 on top of 0b5331a by following ticket repro steps. Tested fix by following same steps and seeing that character can now plow the farm field just fine.
Additional context
Checklist