Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content,port): Wasp Nests #4265

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Conversation

Zlorthishen
Copy link
Contributor

@Zlorthishen Zlorthishen commented Feb 29, 2024

Purpose of change

ports over dda change

Describe the solution

Describe alternatives you've considered

Testing

Additional context

Checklist

Co-Authored-By: Venera3 <72006894+venera3@users.noreply.github.com>
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 29, 2024
Copy link
Contributor

autofix-ci bot commented Feb 29, 2024

The Autofix app has found code style violation and automatically formatted this Pull Request.

I locally edit my commits (e.g: git, github desktop)

Please choose following options:

I'd like to accept the automated commit
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

This PR is complete and I don't want to edit it anymore

It's safe to ignore this message.

I edit this PR through web UI

You can ignore this message and continue working.

I have no idea what this message is talking about

You can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005.

@Zlorthishen Zlorthishen changed the title feat(content,port): Wasp Nest Maps feat(content,port): Wasp Nests Feb 29, 2024
@Zlorthishen Zlorthishen marked this pull request as ready for review February 29, 2024 00:38
@scarf005 scarf005 requested a review from chaosvolt February 29, 2024 15:16
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want these to have a non-zero minimum chance since they're set to unique. Which I'm glad you did, otherwise it would've effectively doubled the maximum number of radio towers in an overmap. :D

data/json/overmap/overmap_special/specials.json Outdated Show resolved Hide resolved
data/json/overmap/overmap_special/specials.json Outdated Show resolved Hide resolved
@scarf005 scarf005 requested a review from chaosvolt February 29, 2024 23:33
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

80% is pretty spicy for 2 new specials but eh, is fine I guess.

@scarf005 scarf005 merged commit ccb8c28 into cataclysmbnteam:main Mar 1, 2024
10 checks passed
@Zlorthishen Zlorthishen deleted the wasp_nest branch March 1, 2024 02:20
@Lamandus
Copy link
Contributor

Lamandus commented Mar 8, 2024

bit late for the party, but you thought of the "tiles map" Symbol, but when using regular letters (old school) you can't differentiate between

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants