fix: enable display and switch of firing mode for shape targetmode #4278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
This PR addresses the issue of not being able to switch firing mode when using birdshot with double barreled shotgun.
With this change, when in TargetMode::Shape and actually using a gun, the firing UI will:
Fixes #4071
Describe the solution
Players can now switch firing modes from the shooting/firing menu when using a gun that fires in a 'shape' / area of effect.
Describe alternatives you've considered
Testing
Made character with double barreled shotgun. Tries this change with both birdshot and buckshot to see that double firing mode can be changed in the shooting ui and that it actually shoots both barrels. Buckshot shooting seems to work the same.
Additional context
Checklist