Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable display and switch of firing mode for shape targetmode #4278

Merged

Conversation

ekaratzas
Copy link
Contributor

Purpose of change

This PR addresses the issue of not being able to switch firing mode when using birdshot with double barreled shotgun.
With this change, when in TargetMode::Shape and actually using a gun, the firing UI will:

  • show the current firing mode
  • provide hotkey for switching firing modes

Fixes #4071

Describe the solution

Players can now switch firing modes from the shooting/firing menu when using a gun that fires in a 'shape' / area of effect.

Describe alternatives you've considered

Testing

Made character with double barreled shotgun. Tries this change with both birdshot and buckshot to see that double firing mode can be changed in the shooting ui and that it actually shoots both barrels. Buckshot shooting seems to work the same.
shotgun_birdshot_firing_mode

Additional context

Checklist

@github-actions github-actions bot added the src changes related to source code. label Mar 2, 2024
@scarf005
Copy link
Member

scarf005 commented Mar 2, 2024

hi, it'd be appreciated to not mention issues by their hash (#123) in PR title, as the links do not work in regular git commits.

image

also, please check https://docs.cataclysmbn.org/en/contribute/changelog_guidelines/ for PR title guideline.

@ekaratzas ekaratzas changed the title enable display and switch of firing mode for shape targetmode #4071 enable display and switch of firing mode for shape targetmode Mar 2, 2024
@ekaratzas ekaratzas changed the title enable display and switch of firing mode for shape targetmode fix: enable display and switch of firing mode for shape targetmode Mar 2, 2024
@ekaratzas
Copy link
Contributor Author

hi, it'd be appreciated to not mention issues by their hash (#123) in PR title, as the links do not work in regular git commits.

image

also, please check https://docs.cataclysmbn.org/en/contribute/changelog_guidelines/ for PR title guideline.

thanks @scarf005 let me know if the latest PR title looks ok.

@scarf005 scarf005 self-requested a review March 2, 2024 01:02
@scarf005 scarf005 self-assigned this Mar 2, 2024
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@scarf005 scarf005 merged commit fbeb2ba into cataclysmbnteam:main Mar 2, 2024
13 checks passed
@ekaratzas ekaratzas deleted the fix-dbshotgun-firing-mode-4071 branch March 10, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't change firing mode with double-barrel shotgun and birdshots
2 participants