feat: residential front lawn nested chunks #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add nested chunks for residential front lawn features
LilShiningMan
changed the title
|
wha |
|
Why'd you close and delete it, it wasn't merged yet? |
|
Oh no! oops. Thought it was successfully merged
…On Fri, Mar 1, 2024 at 8:32 PM Chaosvolt ***@***.***> wrote:
Why'd you close and delete it, it wasn't merged yet?
—
Reply to this email directly, view it on GitHub
<#4281 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANRGAGCVSQQWFCCLYE6YQM3YWFI4XAVCNFSM6AAAAABECWYHQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZUGI4TANRZG4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
approval =/= merge I was gonna wait and make sure all the tests passed just in case I missed something, just to be safe :< |
|
2 PRs and 2 mistakes today. Github isn't my strong suit |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Add nested chunks for residential front lawn features. This will make for more dynamic, more interesting house spawns.
Describe the solution
Create nest container for residential front lawns. Currently there are only 2 variants, to make it easier to review. More will be coming in the future. Using this nest container will make it easy to add more variants down the road without updating individual house files, and also control global spawn rates of variants.
Describe alternatives you've considered
Not adding these and letting houses be more stagnant.
Testing
linted file and spawned both variants in-game.
Additional context
These two chunk variants aren't overly exciting on their own, but with more variants added, I think this could be more interesting overall than having set map features for specific houses.
Checklist