-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: spawn active items on mapgen #4283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can spawn grenades active in houses, or you know, atomic lights
github-actions
bot
added
src
changes related to source code.
JSON
related to game datas in JSON format.
labels
Mar 2, 2024
scarf005
force-pushed
the
feat-mapgen-active
branch
from
March 2, 2024 07:40
a36a4a8
to
e189452
Compare
scarf005
changed the title
feat: spawn active items on mapgen
feat: spawn active items on mapgen
Mar 2, 2024
scarf005
force-pushed
the
feat-mapgen-active
branch
from
March 2, 2024 08:44
e189452
to
879805b
Compare
scarf005
force-pushed
the
feat-mapgen-active
branch
from
March 2, 2024 08:49
879805b
to
4539619
Compare
KheirFerrum
reviewed
Mar 2, 2024
joveeater
reviewed
Mar 2, 2024
Co-authored-by: joveeater <joveasarus@gmail.com>
Coolthulhu
reviewed
Mar 7, 2024
Coolthulhu
previously approved these changes
Mar 7, 2024
Co-authored-by: Coolthulhu <Coolthulhu@gmail.com>
Co-authored-by: Coolthulhu <Coolthulhu@gmail.com>
Coolthulhu
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Describe the solution
cherry-picked solutions from #4073 and #4266:
map::spawn_item
insrc/mapgen.cpp
and replaced withmap::spawn_an_item
as it allows passing item ptr (so we can activate it first)for item groups: sentACTIVATE_ON_PLACE
flag toItem_modifier.custom_flags
insrc/item_factory.cpp
and checked its presence insrc/item_group.cpp
.postprocess_fns: vector<detached_ptr -> detached_ptr>
field inItem_modifier
class that lets you postprocess spawned item in Command pattern.Describe alternatives you've considered
Testing
Checklist
doc/
folder.lang/bn_extract_json_strings.sh
script if it does not support them yet.