Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix lang file compilation in windows msvc #4298

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Mar 4, 2024

Purpose of change

Describe the solution

ported https://github.com/CleverRaven/Cataclysm-DDA/pull/72031/commits by @akrieger.

Describe alternatives you've considered

  • migrate MSVC distribution fully to cmake
  • also install python3

Testing

image

https://github.com/scarf005/Cataclysm-BN/actions/runs/8141808018/job/22249927779

run succeeded in fork.

Additional Context

@SurFlurer helped finding fixes in #4276 (comment).

explicitly compile gettext on msys2.

Co-authored-by: Andrew Krieger <akrieger@users.noreply.github.com>
@scarf005 scarf005 requested a review from olanti-p March 4, 2024 14:30
@scarf005 scarf005 changed the title ci: fix lang file compilation in windows ci: fix lang file compilation in windows msvc Mar 4, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests past and Scarf also tested it so. :>

@scarf005 scarf005 merged commit 5f11abf into cataclysmbnteam:main Mar 4, 2024
9 checks passed
@scarf005 scarf005 deleted the ci-msvc-gettext branch March 21, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows MSVC builds not building pt.3
2 participants