Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): add residential roof chunks and one new residential roof solar variant #4307

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

LilShiningMan
Copy link
Contributor

Purpose of change

Making roofs of residences a tiny bit more dynamic by introducing residential roof chunks. These nested chunks will be any sort of scenes/items you might find on a residential roof. I'd like there to be just a little higher chance of finding a surprise on a rooftop, and to hint at life in the game outside of whatever the player is up to.

Describe the solution

Create the Nested Chunk container for residential roof chunks. I've only added 2 variants at the moment (one spawns a frisbee and baseball, the other a couple of crows perching on the roof) for the moment to make this easier to review. In the future I'd like to add more variants, maybe including some enemy spawns that would make sense (any flying or leaping creatures) as well as some loot (if the player is climbing rooftops to escape monsters, other survivors also likely have been as well, some of whom may have left some gear there for safekeeping, and then never came back).

Describe alternatives you've considered

leaving house rooftops to be dull and lifeless

Testing

linted and spawned in game

Additional context

All in all, I think rooftop spawns should be rather rare, and a nice surprise or bonus, rather than something the player consistently does to check if there is anything up there.

NOTE: crows spawn in flight and promptly fly away, but I think this makes sense -- if the player is noisily climbing a rain gutter and then bursts onto a rooftop, that's bound to cause some panic.
roof chunks crows

roof chunks frisb

I've also added a new residential solar rooftop variant -- a 2x4. I think this will probably be my last variant, as there aren't too many more that make sense for the size, and I doubt we need any more.
solar 2 x 4

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Mar 6, 2024
Copy link
Contributor

autofix-ci bot commented Mar 6, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@scarf005 scarf005 merged commit e8ceea9 into cataclysmbnteam:main Mar 7, 2024
10 checks passed
@LilShiningMan LilShiningMan deleted the roof_chunks branch March 8, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants