feat(content): add residential roof chunks and one new residential roof solar variant #4307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Making roofs of residences a tiny bit more dynamic by introducing residential roof chunks. These nested chunks will be any sort of scenes/items you might find on a residential roof. I'd like there to be just a little higher chance of finding a surprise on a rooftop, and to hint at life in the game outside of whatever the player is up to.
Describe the solution
Create the Nested Chunk container for residential roof chunks. I've only added 2 variants at the moment (one spawns a frisbee and baseball, the other a couple of crows perching on the roof) for the moment to make this easier to review. In the future I'd like to add more variants, maybe including some enemy spawns that would make sense (any flying or leaping creatures) as well as some loot (if the player is climbing rooftops to escape monsters, other survivors also likely have been as well, some of whom may have left some gear there for safekeeping, and then never came back).
Describe alternatives you've considered
leaving house rooftops to be dull and lifeless
Testing
linted and spawned in game
Additional context
All in all, I think rooftop spawns should be rather rare, and a nice surprise or bonus, rather than something the player consistently does to check if there is anything up there.
NOTE: crows spawn in flight and promptly fly away, but I think this makes sense -- if the player is noisily climbing a rain gutter and then bursts onto a rooftop, that's bound to cause some panic.
I've also added a new residential solar rooftop variant -- a 2x4. I think this will probably be my last variant, as there aren't too many more that make sense for the size, and I doubt we need any more.
Checklist