Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit music log spam #4344

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

ekaratzas
Copy link
Contributor

Purpose of change

mp3 music log spam is super annoying

Fixes: #4190

Describe the solution

Describe music once every hour instead of every 5 minutes. It's actually nice when it's a lot less frequent.

Describe alternatives you've considered

Testing

spawn mp3 player + watch. put on mp3 player and turn it on. wait X hours. only see X music messages.

Additional context

A good fix today is better than a perfect fix next year.
mp3

Checklist

@github-actions github-actions bot added the src changes related to source code. label Mar 13, 2024
@scarf005 scarf005 merged commit e5799ef into cataclysmbnteam:main Mar 13, 2024
13 checks passed
@ekaratzas ekaratzas deleted the limit-music-spam branch March 13, 2024 06:30
@JBloodthorn
Copy link

Sincerely, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn off mp3 / music log spam
3 participants